From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTwmg-0005jd-A0 for qemu-devel@nongnu.org; Sun, 21 Apr 2013 12:06:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UTwmc-00029t-VT for qemu-devel@nongnu.org; Sun, 21 Apr 2013 12:06:34 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:45427) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTwmc-00029f-PP for qemu-devel@nongnu.org; Sun, 21 Apr 2013 12:06:30 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 21 Apr 2013 10:06:29 -0600 Received: from d01relay07.pok.ibm.com (d01relay07.pok.ibm.com [9.56.227.147]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 96634C9001A for ; Sun, 21 Apr 2013 12:06:26 -0400 (EDT) Received: from d01av05.pok.ibm.com (d01av05.pok.ibm.com [9.56.224.195]) by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3LG6Q7s40828966 for ; Sun, 21 Apr 2013 12:06:26 -0400 Received: from d01av05.pok.ibm.com (loopback [127.0.0.1]) by d01av05.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3LG6QIn014042 for ; Sun, 21 Apr 2013 12:06:26 -0400 Message-ID: <51740E81.4080909@linux.vnet.ibm.com> Date: Sun, 21 Apr 2013 12:06:25 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1366240040-10730-1-git-send-email-mrhines@linux.vnet.ibm.com> <1366240040-10730-8-git-send-email-mrhines@linux.vnet.ibm.com> <51706E9C.9@redhat.com> <20130420170240.GA16115@redhat.com> <5173E759.5080906@redhat.com> In-Reply-To: <5173E759.5080906@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL v4 07/11] rdma: introduce capability for chunk registration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, quintela@redhat.com, "Michael S. Tsirkin" , qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com On 04/21/2013 09:19 AM, Paolo Bonzini wrote: > Il 20/04/2013 19:02, Michael S. Tsirkin ha scritto: >>>> I guess the opposite sense could be named 'x-rdma-pin-all'; default >>>> false means to do chunk registration and release, >> chunk release only happens after migration is complete unfortunately. >> This means that eventually all initialized memory is pinned, regardless >> of the setting (this is fixable but there's no plan to fix this, at this >> point). So pin-all might be misleading to some. >> >> I agree 'chunk' is unnecessarily low level though. >> The only difference ATM is pinning of uninitialized memory so I think a >> better name would be 'x-rdma-pin-uninitialized' or some such. >> > x-rdma-pin-all is a better choice. x-rdma-pin-uninitialized is also too > low level. > > Since this series is likely to miss 1.5 at this point, we could > implement the unregistration part of the protocol in the destination. > This way, any heuristic we add to the source will not break backwards > compatibility. > > Paolo > OK, I will rename the capability.... - Michael