From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UU6MY-00005M-AM for qemu-devel@nongnu.org; Sun, 21 Apr 2013 22:20:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UU6MX-0001WX-Cn for qemu-devel@nongnu.org; Sun, 21 Apr 2013 22:20:14 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:44064) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UU6MX-0001WC-8f for qemu-devel@nongnu.org; Sun, 21 Apr 2013 22:20:13 -0400 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 21 Apr 2013 22:20:10 -0400 Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 3CF23C90025 for ; Sun, 21 Apr 2013 22:20:06 -0400 (EDT) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3M2K6h6299726 for ; Sun, 21 Apr 2013 22:20:06 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3M2K5Ks016337 for ; Sun, 21 Apr 2013 22:20:06 -0400 Message-ID: <51749E52.5050000@linux.vnet.ibm.com> Date: Mon, 22 Apr 2013 10:20:02 +0800 From: Dong Xu Wang MIME-Version: 1.0 References: <1365575111-4476-1-git-send-email-wdongxu@linux.vnet.ibm.com> In-Reply-To: <1365575111-4476-1-git-send-email-wdongxu@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V13 0/6] replace QEMUOptionParameter with QemuOpts parser List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dong Xu Wang Cc: kwolf@redhat.com, wdongxu@cn.ibm.com, qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com On 2013/4/10 14:25, Dong Xu Wang wrote: > These patches will replace QEMUOptionParameter with QemuOpts. Change logs > please go to each patch's commit message. > > Dong Xu Wang (6): > add def_value_str in QemuOptDesc struct and rewrite qemu_opts_print > avoid duplication of default value in QemuOpts > Create four QemuOptsList related functions > create some QemuOpts functons > Use QemuOpts support in block layer > remove QEMUOptionParameter related functions and struct > > block.c | 98 ++++---- > block/cow.c | 46 ++-- > block/gluster.c | 37 ++-- > block/iscsi.c | 35 ++- > block/qcow.c | 61 +++-- > block/qcow2.c | 173 ++++++++------- > block/qed.c | 86 ++++--- > block/qed.h | 2 +- > block/raw-posix.c | 59 +++-- > block/raw-win32.c | 31 +-- > block/raw.c | 30 +-- > block/rbd.c | 62 +++--- > block/sheepdog.c | 79 ++++--- > block/vdi.c | 70 +++--- > block/vmdk.c | 90 ++++---- > block/vpc.c | 57 ++--- > block/vvfat.c | 11 +- > include/block/block.h | 5 +- > include/block/block_int.h | 6 +- > include/qemu/option.h | 49 ++-- > qemu-img.c | 61 +++-- > util/qemu-option.c | 555 ++++++++++++++++++++-------------------------- > 22 files changed, 791 insertions(+), 912 deletions(-) > Ping.. Can anyone give some comments? That will be very grateful..