From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53868)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UUCaS-000090-JX
	for qemu-devel@nongnu.org; Mon, 22 Apr 2013 04:59:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UUCaR-00009t-Il
	for qemu-devel@nongnu.org; Mon, 22 Apr 2013 04:59:00 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41224)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UUCaR-00009c-At
	for qemu-devel@nongnu.org; Mon, 22 Apr 2013 04:58:59 -0400
Message-ID: <5174FBC3.30707@redhat.com>
Date: Mon, 22 Apr 2013 10:58:43 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1366260005.git.peter.crosthwaite@xilinx.com>
	<d990882bb4317e4d8d784e6e296d45d3b27ee236.1366260005.git.peter.crosthwaite@xilinx.com>
	<CAAu8pHvhB97aO4_-nJfvOn1yk5UqgKPkzCB6JaWR0O+Sh9Z_Ng@mail.gmail.com>
	<5173E697.4050606@redhat.com>
	<CAEgOgz7_pWoJ2q=xUvVNkQyKjG0_jc-wCEtS_hPRUTQgBZDF1Q@mail.gmail.com>
In-Reply-To: <CAEgOgz7_pWoJ2q=xUvVNkQyKjG0_jc-wCEtS_hPRUTQgBZDF1Q@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 3/3] configure/Make: Build libfdt from
 submodule DTC
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, qemu-devel <qemu-devel@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>

Il 22/04/2013 06:45, Peter Crosthwaite ha scritto:
> Hi Paolo, Blue,
> 
> On Sun, Apr 21, 2013 at 11:16 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> Il 20/04/2013 20:42, Blue Swirl ha scritto:
>>> This is not entirely correct, I get these errors:
>>> mingw32:
>>>      CC libfdt/fdt.o
>>> cc1: warnings being treated as errors
>>> /src/qemu/dtc/libfdt/fdt.c:1: warning: -fPIC ignored for target (all
>>> code is position independent)
>>>
> 
> This is coming from the dtc makefile which explicitly passes in -fPIC
> via its default CFLAGS. I tried fixing by setting the Make invocation
> to replace CFLAGS entirely, which in effect removes the -fPIC: But I
> suffer a similar (later) failure to the one you posted below:
> 
>   LINK  arm-softmmu/qemu-system-arm
> /usr/bin/ld: /home/peterc/Petalogix/Internal/plgx_src/qemu-build/dtc/libfdt/libfdt.a(fdt.o):
> relocation R_X86_64_32S against `.rodata' can not be used when making
> a shared object; recompile with -fPIC
> /home/peterc/Petalogix/Internal/plgx_src/qemu-build/dtc/libfdt/libfdt.a:
> could not read symbols: Bad value
> 
> Looks like QEMU mandates that all static objects are -fPIC. A bit of
> googling suggests that this error is mingw specific in that mingw
> can't handle -fPIC.

Right, that's because QEMU is built as a position-independent executable.

PIE requirements actually are a bit less strict than -fPIC.  Your
solution of passing the compilation flags sounds good, but do you pass
-Werror too?

Paolo