From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35388) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUDBh-0004br-4w for qemu-devel@nongnu.org; Mon, 22 Apr 2013 05:37:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UUDBf-0004uW-Uf for qemu-devel@nongnu.org; Mon, 22 Apr 2013 05:37:28 -0400 Received: from mail-qc0-x236.google.com ([2607:f8b0:400d:c01::236]:65199) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUDBf-0004uR-QM for qemu-devel@nongnu.org; Mon, 22 Apr 2013 05:37:27 -0400 Received: by mail-qc0-f182.google.com with SMTP id k19so1749771qcs.13 for ; Mon, 22 Apr 2013 02:37:27 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <517504CB.6040303@redhat.com> Date: Mon, 22 Apr 2013 11:37:15 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1366275680-15416-1-git-send-email-kraxel@redhat.com> <87ppxq6hmn.fsf@blackfin.pond.sub.org> <5174DEE5.20406@redhat.com> In-Reply-To: <5174DEE5.20406@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: lcapitulino@redhat.com, Markus Armbruster , qemu-devel@nongnu.org Il 22/04/2013 08:55, Gerd Hoffmann ha scritto: >>> >> Question for the libvirt guys: Is it ok for libvirt to just extend the >>> >> existing screendump command? Can libvirt figure there is a new >>> >> (optional) parameter? See patch #5. >> > >> > Nope, QMP can't do that. I argued for such capabilities, but the >> > "create a new command" philosophy prevailed. >> > >> > Go forth and multiply commands! And have fun picking command names that >> > aren't fugly. > Oh joy. Lets just enumerate things & use "screendump2" ... QMP can't do that _yet_. Let's fix it instead... Paolo