From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUFqd-0001AK-IB for qemu-devel@nongnu.org; Mon, 22 Apr 2013 08:27:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UUFqb-0005Qh-Nq for qemu-devel@nongnu.org; Mon, 22 Apr 2013 08:27:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4874) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUFqb-0005QO-4C for qemu-devel@nongnu.org; Mon, 22 Apr 2013 08:27:53 -0400 Message-ID: <51752C9C.10200@redhat.com> Date: Mon, 22 Apr 2013 14:27:08 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1366063976-4909-1-git-send-email-imammedo@redhat.com> <1366063976-4909-12-git-send-email-imammedo@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 11/16] introduce ICC bus/device/bridge List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: aliguori@us.ibm.com, ehabkost@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, lcapitulino@redhat.com, jfrei@linux.vnet.ibm.com, yang.z.zhang@intel.com, Igor Mammedov , afaerber@suse.de, lig.fnst@cn.fujitsu.com, rth@twiddle.net Il 22/04/2013 13:39, Peter Maydell ha scritto: >> > ... to provide hotplug-able bus. >> > >> > * icc-bridge will serve as a parent for icc-bus and provide >> > mmio mapping services to child icc-devices. >> > * icc-device will replace SysBusDevice as a parent of APIC >> > and IOAPIC devices. >> > >> > Signed-off-by: Igor Mammedov >> > --- >> > v2: >> > * Rebase on top the last HW reorganization series. >> > * Move hw/icc_bus.c into hw/cpu/ and hw/icc_bus.h include/hw/i386/ > This seems inconsistent. I think the header should be in > include/hw/cpu/ to match the location of the .c file. Agreed. Paolo