Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time

[Gerd Hoffmann <kraxel@redhat.com>]

  Hi,

>> But isn't this patch the equivalent of repeatedly pressing and releasing a
>> key? Shouldn't this be implemented at a lower-level layer like the input
>> subsystem?

ps/2 keyboard emulation would probably the place to do it.

I'm pretty sure not all keyboard types have auto-repeat.  The linux
kernel input layer has code to generate the auto-repeat kbd events in
software, and that code is there for a reason I guess ...

> No, this patch is implementing what the microcontroller does, i.e. 10
> presses + 1 release.  I'm not sure it is the right level to do it (the
> rate/delay should be at least customizable from the board), but the
> logic is right and if someone else needs more configurability we can add
> it later.

IIRC the (ps/2) kbd controller can be programmed with rate+delay.

cheers,
  Gerd