From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52564)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1UUGtq-0006ZF-Gk
	for qemu-devel@nongnu.org; Mon, 22 Apr 2013 09:35:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1UUGtk-0008Fz-Mc
	for qemu-devel@nongnu.org; Mon, 22 Apr 2013 09:35:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:11923)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1UUGtk-0008Fg-FG
	for qemu-devel@nongnu.org; Mon, 22 Apr 2013 09:35:12 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3MDZAk0017119
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 22 Apr 2013 09:35:11 -0400
Message-ID: <51753C8B.5080504@redhat.com>
Date: Mon, 22 Apr 2013 15:35:07 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1366346658-4680-1-git-send-email-akong@redhat.com>
	<5172BD04.2050504@redhat.com>
	<20130422073252.GC1938@t430s.nay.redhat.com>
	<20130422080935.GA29975@t430s.nay.redhat.com>
	<517503E0.1080906@redhat.com> <20130422084350.17b2941b@redhat.com>
	<51753505.9020107@redhat.com>
In-Reply-To: <51753505.9020107@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] monitor: intervally send down events to
 guest in hold time
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Amos Kong <akong@redhat.com>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

  Hi,

>> But isn't this patch the equivalent of repeatedly pressing and releasing a
>> key? Shouldn't this be implemented at a lower-level layer like the input
>> subsystem?

ps/2 keyboard emulation would probably the place to do it.

I'm pretty sure not all keyboard types have auto-repeat.  The linux
kernel input layer has code to generate the auto-repeat kbd events in
software, and that code is there for a reason I guess ...

> No, this patch is implementing what the microcontroller does, i.e. 10
> presses + 1 release.  I'm not sure it is the right level to do it (the
> rate/delay should be at least customizable from the board), but the
> logic is right and if someone else needs more configurability we can add
> it later.

IIRC the (ps/2) kbd controller can be programmed with rate+delay.

cheers,
  Gerd