From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51553) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUIF6-0002Sn-Hp for qemu-devel@nongnu.org; Mon, 22 Apr 2013 11:01:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UUIF5-0008FE-3p for qemu-devel@nongnu.org; Mon, 22 Apr 2013 11:01:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14661) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUIF4-0008F9-Sb for qemu-devel@nongnu.org; Mon, 22 Apr 2013 11:01:19 -0400 Message-ID: <51755075.1000008@redhat.com> Date: Mon, 22 Apr 2013 09:00:05 -0600 From: Eric Blake MIME-Version: 1.0 References: <1366365123-5412-1-git-send-email-akong@redhat.com> <51716101.8090705@redhat.com> <20130422114841.GA4053@t430s.nay.redhat.com> <517527FC.2090808@redhat.com> In-Reply-To: <517527FC.2090808@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2MSTCTDHVHNSNTQDSLMNW" Subject: Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, jyang@redhat.com, lcapitulino@redhat.com, Amos Kong This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2MSTCTDHVHNSNTQDSLMNW Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/22/2013 06:07 AM, Paolo Bonzini wrote: > Il 22/04/2013 13:48, Amos Kong ha scritto: >>>>>> Libvirt doesn't have a stable way to know option support >>>>>> detail. This patch introdued a new qmp command to query >>>>>> configuration schema information. hmp command isn't added. >>>> >>>> Can you introspect QemuOpts instead? All new options are added ther= e. >> >> It would be exact to use QemuOpts. I tried to output the vm_config_gro= ups[] >> in qemu-config.c, but it seems not enough. (desc list of -netdev, -dri= ve, >> -device are all empty) >=20 > That's expected because they are parsed otherwise, depending on the > backend type. -chardev is currently working but it's an implementation= > detail. Libvirt cares most about newly added options, which should use qemuOpts all the way. We can understand that legacy options like -netdev might not yet use qemuOpts, but they are also legacy options, and therefore libvirt can already assume they exist since at least qemu 1.3 (when libvirt switched over to QMP probing). If we later add a new feature to -netdev, we should also convert -netdev to qemuOpts at that time, so that libvirt would know whether the new feature is available. At any rate, we really DO want introspection, and having it in 1.5 is a worthwhile goal. Even if the introspection turns up empty on legacy options, having it for the sake of new options is worth the effort. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2MSTCTDHVHNSNTQDSLMNW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRdVB1AAoJEKeha0olJ0Nq62AH/2xJP/lL+44kUe0KIETY8bOh IGZzsN9d4FZJoZH9REFHYQHnMnBVEiXTPKFNX+ZrACoA83+bfktcJKwduPuijpG6 VDFvuUGZSLb2sr5HirQCuG+q8uxorCdmMrfg5tTyaDmpRc6pHn0EEOSLbBsBw91T 202A4zw+zQBrFLh5BW29IOdDqexZU4Uw6o4GoU3UEELFI4JcS1jq/IjmGPAUgB2+ V1cwp/3dyE3GBsZCTjgDBlbYy7FrgETFYsvTXPfauV7gDV6PCX6c/VyE1uI+DT7C BTGPNDXI438nDt6O9cpD9pEo4XhkDxZQNOHcZq+WlDxUwPSfPn39k7d/Abl4qHQ= =fytw -----END PGP SIGNATURE----- ------enig2MSTCTDHVHNSNTQDSLMNW--