From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUIGu-0005L6-Om for qemu-devel@nongnu.org; Mon, 22 Apr 2013 11:03:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UUIGr-0000Qt-Ig for qemu-devel@nongnu.org; Mon, 22 Apr 2013 11:03:12 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34272 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUIGr-0000QW-8f for qemu-devel@nongnu.org; Mon, 22 Apr 2013 11:03:09 -0400 Message-ID: <5175512C.90305@suse.de> Date: Mon, 22 Apr 2013 17:03:08 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1366063976-4909-1-git-send-email-imammedo@redhat.com> <1366063976-4909-14-git-send-email-imammedo@redhat.com> In-Reply-To: <1366063976-4909-14-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 13/16] target-i386: replace MSI_SPACE_SIZE with APIC_SPACE_SIZE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: aliguori@us.ibm.com, ehabkost@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, lcapitulino@redhat.com, jfrei@linux.vnet.ibm.com, yang.z.zhang@intel.com, pbonzini@redhat.com, lig.fnst@cn.fujitsu.com, rth@twiddle.net Am 16.04.2013 00:12, schrieb Igor Mammedov: > ... and put APIC_SPACE_SIZE in public header so that it could be > reused later elsewhere. >=20 > Signed-off-by: Igor Mammedov Reviewed-by: Andreas F=E4rber Andreas > --- > hw/i386/kvm/apic.c | 2 +- > hw/intc/apic.c | 2 +- > hw/xen/xen_apic.c | 2 +- > include/hw/i386/apic_internal.h | 2 -- > target-i386/cpu.h | 1 + > 5 files changed, 4 insertions(+), 5 deletions(-) >=20 > diff --git a/hw/i386/kvm/apic.c b/hw/i386/kvm/apic.c > index c6ff982..8f80425 100644 > --- a/hw/i386/kvm/apic.c > +++ b/hw/i386/kvm/apic.c > @@ -174,7 +174,7 @@ static const MemoryRegionOps kvm_apic_io_ops =3D { > static void kvm_apic_init(APICCommonState *s) > { > memory_region_init_io(&s->io_memory, &kvm_apic_io_ops, s, "kvm-api= c-msi", > - MSI_SPACE_SIZE); > + APIC_SPACE_SIZE); > =20 > if (kvm_has_gsi_routing()) { > msi_supported =3D true; > diff --git a/hw/intc/apic.c b/hw/intc/apic.c > index 2d79a9e..756dff0 100644 > --- a/hw/intc/apic.c > +++ b/hw/intc/apic.c > @@ -874,7 +874,7 @@ static const MemoryRegionOps apic_io_ops =3D { > static void apic_init(APICCommonState *s) > { > memory_region_init_io(&s->io_memory, &apic_io_ops, s, "apic-msi", > - MSI_SPACE_SIZE); > + APIC_SPACE_SIZE); > =20 > s->timer =3D qemu_new_timer_ns(vm_clock, apic_timer, s); > local_apics[s->idx] =3D s; > diff --git a/hw/xen/xen_apic.c b/hw/xen/xen_apic.c > index a2eb8a1..a958782 100644 > --- a/hw/xen/xen_apic.c > +++ b/hw/xen/xen_apic.c > @@ -39,7 +39,7 @@ static const MemoryRegionOps xen_apic_io_ops =3D { > static void xen_apic_init(APICCommonState *s) > { > memory_region_init_io(&s->io_memory, &xen_apic_io_ops, s, "xen-api= c-msi", > - MSI_SPACE_SIZE); > + APIC_SPACE_SIZE); > =20 > #if defined(CONFIG_XEN_CTRL_INTERFACE_VERSION) \ > && CONFIG_XEN_CTRL_INTERFACE_VERSION >=3D 420 > diff --git a/include/hw/i386/apic_internal.h b/include/hw/i386/apic_int= ernal.h > index 578241f..aac6290 100644 > --- a/include/hw/i386/apic_internal.h > +++ b/include/hw/i386/apic_internal.h > @@ -66,8 +66,6 @@ > =20 > #define MAX_APICS 255 > =20 > -#define MSI_SPACE_SIZE 0x100000 > - > typedef struct APICCommonState APICCommonState; > =20 > #define TYPE_APIC_COMMON "apic-common" > diff --git a/target-i386/cpu.h b/target-i386/cpu.h > index cf1b05c..65cf97d 100644 > --- a/target-i386/cpu.h > +++ b/target-i386/cpu.h > @@ -1269,5 +1269,6 @@ uint32_t x86_cpu_apic_id_from_index(unsigned int = cpu_index); > void enable_compat_apic_id_mode(void); > =20 > #define APIC_DEFAULT_ADDRESS 0xfee00000 > +#define APIC_SPACE_SIZE 0x100000 > =20 > #endif /* CPU_I386_H */ >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg