From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58421) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUIY0-0001C4-1p for qemu-devel@nongnu.org; Mon, 22 Apr 2013 11:20:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UUIXv-0007Ln-Gx for qemu-devel@nongnu.org; Mon, 22 Apr 2013 11:20:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19456) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUIXu-0007LZ-U8 for qemu-devel@nongnu.org; Mon, 22 Apr 2013 11:20:47 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3MFKkxF020889 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 22 Apr 2013 11:20:46 -0400 Message-ID: <5175554B.20607@redhat.com> Date: Mon, 22 Apr 2013 17:20:43 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1366346658-4680-1-git-send-email-akong@redhat.com> <5172BD04.2050504@redhat.com> <20130422073252.GC1938@t430s.nay.redhat.com> <20130422080935.GA29975@t430s.nay.redhat.com> <517503E0.1080906@redhat.com> <20130422084350.17b2941b@redhat.com> <51753505.9020107@redhat.com> <51753C8B.5080504@redhat.com> <517549F2.3020809@redhat.com> In-Reply-To: <517549F2.3020809@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Amos Kong , qemu-devel , Luiz Capitulino Hi, > Yes, if PS/2 keyboard emulation emulated the autorepeat rate/delay, then > the code we have in QMP would just work. However it would need to be > done for all devices (ignoring repeated keydown events from the upper > layers, and creating its own repeated event). So it makes sense to have > it in common code and have keyboard devices just tell common code the > desired rate/delay. Yep, that'll work too. > BTW, how do we currently handle stuck keys across migration (where the > key-up event never reaches the guest because the key was never pressed > in the first place on the destination)? We don't. >> IIRC the (ps/2) kbd controller can be programmed with rate+delay. > > Yes, but we ignore the command. For the PS/2 keyboard, I think what we > send now to the guest is based on the rate/delay that is emulated in > software by the GUI layers (for Unix it should just be X11 for all of > SDL/VNC/Spice). Exactly. Thats why keys getting stuck on migration isn't a big issue in practice. cheers, Gerd