From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44636) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUJ7o-0008H1-70 for qemu-devel@nongnu.org; Mon, 22 Apr 2013 11:57:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UUJ7m-0005Ss-Gw for qemu-devel@nongnu.org; Mon, 22 Apr 2013 11:57:52 -0400 Received: from cantor2.suse.de ([195.135.220.15]:37003 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUJ7m-0005Sk-Ag for qemu-devel@nongnu.org; Mon, 22 Apr 2013 11:57:50 -0400 Message-ID: <51755DFD.7040904@suse.de> Date: Mon, 22 Apr 2013 17:57:49 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1366107190-30853-1-git-send-email-kraxel@redhat.com> <1366107190-30853-8-git-send-email-kraxel@redhat.com> <87txn4t2b6.fsf@blackfin.pond.sub.org> In-Reply-To: <87txn4t2b6.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 7/7] use libusb for usb-host List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Markus Armbruster , Anthony Liguori , qemu-devel@nongnu.org Am 18.04.2013 15:07, schrieb Markus Armbruster: > Gerd Hoffmann writes: >=20 >> Reimplement usb-host on top of libusb. >> Reasons to do this: >> >> (1) Largely rewritten from scratch, nice opportunity to kill historic= al >> cruft. >> (2) Offload usbfs handling to libusb. >> (3) Have a single portable code base instead of bsd + linux variants. >> (4) Bring usb-host support to any platform supported by libusbx. >> >> For now this goes side-by-side to the existing code. That is only to >> simplify regression testing though, at the end of the day I want remov= e >> the old code and support libusb exclusively. Merge early in 1.5 cycle= , >> remove the old code after 1.5 release or something like this. >> >> Thanks to qdev the old and new code can coexist nicely on linux. Just >> use "-device usb-host-linux" to use the old linux driver instead of th= e >> libusb one (which takes over the "usb-host" name). >> >> The bsd driver isn't qdev'ified so it isn't that easy for bsd. >> I didn't bother making it runtime switchable, so you have to rebuild >> qemu with --disable-libusb to get back the old code. >=20 > Breaks the build for me (Fedora 17's libusb1-devel-1.0.9-0.6.rc1): >=20 > CC hw/usb/host-libusb.o > /home/armbru/work/qemu/hw/usb/host-libusb.c:1254:217: error: =E2=80=98L= IBUSB_LOG_LEVEL_WARNING=E2=80=99 undeclared here (not in a function) Same on openSUSE 12.3 (1.0.9-5.1.1) - any fix cooking for this, Gerd? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg