Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 978 bytes --]

On 04/22/2013 11:03 AM, Paolo Bonzini wrote:
>> It'd be *much* nicer to return the screenshot data via the QMP session
>> instead of writing it to a file.  So let's take the opportunity to fix
>> the command.

That's a lot of data to be encoding into JSON.

> 
> That's debatable... the "nicest" way could also be to pass a pipe fd and
> retrieve the dump from that fd.  That's quite easy to do with fdsets.
> The choice is between implementing SCM_RIGHTS sendfd and a base64 decoder.

If the existing filename can already be used with fdsets, then libvirt
can already achieve pass to pipe - and pass to pipe is indeed the nicest
way to then get alternate formats without having to decode lots of JSON,
since there are conversion utilities that can take ppm on input and
output other formats without having to teach qemu those other output
formats.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]