From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUKSV-00057h-0o for qemu-devel@nongnu.org; Mon, 22 Apr 2013 13:23:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UUKST-0006bo-JV for qemu-devel@nongnu.org; Mon, 22 Apr 2013 13:23:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32594) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUKST-0006bP-6P for qemu-devel@nongnu.org; Mon, 22 Apr 2013 13:23:17 -0400 Message-ID: <51757202.1070503@redhat.com> Date: Mon, 22 Apr 2013 11:23:14 -0600 From: Eric Blake MIME-Version: 1.0 References: <1366275680-15416-1-git-send-email-kraxel@redhat.com> <87ppxq6hmn.fsf@blackfin.pond.sub.org> <5174DEE5.20406@redhat.com> <517504CB.6040303@redhat.com> <20130422085043.4a3e891c@redhat.com> <51753471.5080803@redhat.com> <8738uiqzm1.fsf@codemonkey.ws> <51756D68.1050705@redhat.com> In-Reply-To: <51756D68.1050705@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2HUFXHBKXQJNFSPETHALW" Subject: Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Anthony Liguori , Luiz Capitulino , Markus Armbruster , Gerd Hoffmann This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2HUFXHBKXQJNFSPETHALW Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/22/2013 11:03 AM, Paolo Bonzini wrote: >> It'd be *much* nicer to return the screenshot data via the QMP session= >> instead of writing it to a file. So let's take the opportunity to fix= >> the command. That's a lot of data to be encoding into JSON. >=20 > That's debatable... the "nicest" way could also be to pass a pipe fd an= d > retrieve the dump from that fd. That's quite easy to do with fdsets. > The choice is between implementing SCM_RIGHTS sendfd and a base64 decod= er. If the existing filename can already be used with fdsets, then libvirt can already achieve pass to pipe - and pass to pipe is indeed the nicest way to then get alternate formats without having to decode lots of JSON, since there are conversion utilities that can take ppm on input and output other formats without having to teach qemu those other output formats. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2HUFXHBKXQJNFSPETHALW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRdXICAAoJEKeha0olJ0NqPegH/iAC0wYXVkJaDsRYWlM7XLM1 1GALjnJRfPrnJOGR04F0ln2kuHh+B0+8TpDE9+eFD2kVTOtpG5/VkQItusQ4L7xu NI0SRuBbIW2DyIKtFesrUCmS2kJyUHbZqi4kKFTTp1dtOOoj1kShkvD0hJWx588H 8wMc6PHRXZsUOwvr7PcfvLjaladt02D5sFvUK97oniMimgzWBnmU8DRWHNpTVeKH OLppXRH4vO3UYHpLjci4cTb9v6R5KyBr+0TqIhdCekG7DRLlTvBYl/3hL9l8Fgko copRN6RKnHHOtchwWU3M212jayZr/0RjoRK+FyG2AIXPHGs6YXg4qQukvaLGCho= =kwUd -----END PGP SIGNATURE----- ------enig2HUFXHBKXQJNFSPETHALW--