From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUNIF-00051v-7s for qemu-devel@nongnu.org; Mon, 22 Apr 2013 16:24:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UUNIE-0007mO-19 for qemu-devel@nongnu.org; Mon, 22 Apr 2013 16:24:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUNID-0007m5-Od for qemu-devel@nongnu.org; Mon, 22 Apr 2013 16:24:53 -0400 Message-ID: <51759C91.9030008@redhat.com> Date: Mon, 22 Apr 2013 14:24:49 -0600 From: Eric Blake MIME-Version: 1.0 References: <1366579081-6857-1-git-send-email-mrhines@linux.vnet.ibm.com> <1366579081-6857-11-git-send-email-mrhines@linux.vnet.ibm.com> In-Reply-To: <1366579081-6857-11-git-send-email-mrhines@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2HJSACOFKJGLHGFVPFEGH" Subject: Re: [Qemu-devel] [PATCH v5 10/12] rdma: introduce capability x-rdma-pin-all List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mrhines@linux.vnet.ibm.com Cc: aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2HJSACOFKJGLHGFVPFEGH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/21/2013 03:17 PM, mrhines@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" >=20 > This capability allows you to disable dynamic chunk registration > for better throughput on high-performance links. >=20 > For example, using an 8GB RAM virtual machine with all 8GB of memory in= > active use and the VM itself is completely idle using a 40 gbps infinib= and link: >=20 > 1. x-pin-all disabled total time: approximately 7.5 seconds @ 9.5 Gbps > 2. x-pin-all enabled total time: approximately 4 seconds @ 26 Gbps Naming here doesn't match the actual bit name; but it is obvious enough to know what you meant. Thanks for doing this, by the way - the default-to-disabled is a bit nicer to manage from libvirt's perspective. >=20 > These numbers would of course scale up to whatever size virtual machine= > you have to migrate using RDMA. >=20 > Enabling this feature does *not* have any measurable affect on > migration *downtime*. This is because, without this feature, all of the= > memory will have already been registered already in advance during > the bulk round and does not need to be re-registered during the success= ive > iteration rounds. >=20 > Signed-off-by: Michael R. Hines > --- > include/migration/migration.h | 2 ++ > migration.c | 9 +++++++++ > qapi-schema.json | 7 ++++++- > 3 files changed, 17 insertions(+), 1 deletion(-) > +++ b/qapi-schema.json > @@ -602,10 +602,15 @@ > # This feature allows us to minimize migration traffic for ce= rtain work > # loads, by sending compressed difference of the pages > # > +# @x-rdma-pin-all: (since 1.5) Controls whether or not the entire VM m= emory footprint is=20 Trailing whitespace, and line longer than 80 columns. You ought to rewrap this, and make sure it passes checkpatch.pl. But since that is whitespace-only, feel free to add: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2HJSACOFKJGLHGFVPFEGH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRdZyRAAoJEKeha0olJ0NqrPYH/iaLmDGS5nahlJmmvTuPkPcw 5+COA7iAqLJVGiJzIaUcLLeqE+qhXc8vsuJcmKoA+QRTIsNnV5xm3S5gvSptmELh UdTq3+2vLpFij91YtbzHA/Vol+qdN4Y1fZH7KPxtQPyEl4WYPqV2vlvT6xOpIJWL OY4k9DZmsHNWn1+WIQ+P+8JG6ECCTxhK7p9GaBSnLQKkAXkNTt3l6BWQj+7jyXQE csKLbgLoZOQkQJfub/o02xo0rZ8sq9Rqjnn6la3lyHF9GBAm4RUoYCKKZ2DIZbFI +GNm/aWpn/s+nBtWRNEFfAkFbH56UdjPnaq4KynsYYmJuEWY9/I0nMscxfWdOEo= =UdSm -----END PGP SIGNATURE----- ------enig2HJSACOFKJGLHGFVPFEGH--