From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:43131)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1UUVaE-0003y7-05
	for qemu-devel@nongnu.org; Tue, 23 Apr 2013 01:16:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1UUVaC-0006uk-Hn
	for qemu-devel@nongnu.org; Tue, 23 Apr 2013 01:16:01 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46778)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1UUVaC-0006uU-8J
	for qemu-devel@nongnu.org; Tue, 23 Apr 2013 01:16:00 -0400
Message-ID: <51761909.2010407@redhat.com>
Date: Tue, 23 Apr 2013 07:15:53 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1366275680-15416-1-git-send-email-kraxel@redhat.com>
	<87ppxq6hmn.fsf@blackfin.pond.sub.org>
	<5174DEE5.20406@redhat.com> <517504CB.6040303@redhat.com>
	<20130422085043.4a3e891c@redhat.com>
	<51753471.5080803@redhat.com> <8738uiqzm1.fsf@codemonkey.ws>
	<51756D68.1050705@redhat.com> <51757202.1070503@redhat.com>
In-Reply-To: <51757202.1070503@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent
 screendump monitor command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Luiz Capitulino <lcapitulino@redhat.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

On 04/22/13 19:23, Eric Blake wrote:
> On 04/22/2013 11:03 AM, Paolo Bonzini wrote:
>>> It'd be *much* nicer to return the screenshot data via the QMP session
>>> instead of writing it to a file.  So let's take the opportunity to fix
>>> the command.
> 
> That's a lot of data to be encoding into JSON.
> 
>>
>> That's debatable... the "nicest" way could also be to pass a pipe fd and
>> retrieve the dump from that fd.  That's quite easy to do with fdsets.
>> The choice is between implementing SCM_RIGHTS sendfd and a base64 decoder.
> 
> If the existing filename can already be used with fdsets,

It can't.  Easily fixable though.  Question is how libvirt then can
figure fdsets for screendumps do work ...

cheers,
  Gerd