From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUYp3-0001NQ-QS for qemu-devel@nongnu.org; Tue, 23 Apr 2013 04:43:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UUYp2-0005D3-Dz for qemu-devel@nongnu.org; Tue, 23 Apr 2013 04:43:33 -0400 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:39065) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUYp2-0005Cx-5g for qemu-devel@nongnu.org; Tue, 23 Apr 2013 04:43:32 -0400 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 23 Apr 2013 09:41:50 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 5D0C41B0805F for ; Tue, 23 Apr 2013 09:43:27 +0100 (BST) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps3075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3N8hH1053608670 for ; Tue, 23 Apr 2013 08:43:17 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost.localdomain [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3N8hQTI025779 for ; Tue, 23 Apr 2013 02:43:27 -0600 Message-ID: <517649AE.20709@de.ibm.com> Date: Tue, 23 Apr 2013 10:43:26 +0200 From: Christian Borntraeger MIME-Version: 1.0 References: <1366658298-9275-1-git-send-email-agraf@suse.de> <1366658298-9275-6-git-send-email-agraf@suse.de> In-Reply-To: <1366658298-9275-6-git-send-email-agraf@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 05/12] S390: ccw firmware: Add main program List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel@nongnu.org, Dominik Dingel On 22/04/13 21:18, Alexander Graf wrote: > This C file is the main driving piece of the s390 ccw firmware. It > provides a search for a workable block device, sets it as the default > to boot off of and boots from it. > > Signed-off-by: Alexander Graf > --- > pc-bios/s390-ccw/main.c | 56 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 56 insertions(+), 0 deletions(-) > create mode 100644 pc-bios/s390-ccw/main.c > > diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c > new file mode 100644 > index 0000000..0913aac > --- /dev/null > +++ b/pc-bios/s390-ccw/main.c > @@ -0,0 +1,56 @@ > +/* > + * S390 virtio-ccw loading program > + * > + * Copyright (c) 2013 Alexander Graf > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or (at > + * your option) any later version. See the COPYING file in the top-level > + * directory. > + */ > + > +#include "s390-ccw.h" > + > +struct subchannel_id blk_schid; > +char stack[PAGE_SIZE * 8] __attribute__((__aligned__(PAGE_SIZE))); > + > +void virtio_panic(const char *string) > +{ > + sclp_print(string); > + while (1) { } > +} > + > +static void virtio_setup(void) > +{ > + struct irb irb; > + int i; > + int r; > + bool found = false; > + > + blk_schid.one = 1; > + > + for (i = 0; i < 0x10000; i++) { > + blk_schid.sch_no = i; > + r = tsch(blk_schid, &irb); > + if (r != 3) { > + if (virtio_is_blk(blk_schid)) { > + found = true; > + break; > + } > + } > + } > + > + if (!found) { > + virtio_panic("No virtio-blk device found!\n"); > + } > + > + virtio_setup_block(blk_schid); > +} > + > +int main(void) > +{ > + sclp_setup(); The sclp patch should probably be moved before this one... > + virtio_setup(); > + if (zipl_load() < 0) ...as well as the bootmap loader > + sclp_print("Failed to load OS from hard disk\n"); > + while (1) { } This would waste host cpus spinning, no? Please do a disabled wait. The easiest way might be a short assember routine: .globl disabled_wait disabled_wait: larl %r1,disabled_wait_psw lpswe 0(%r1) .align 8 disabled_wait_psw: .quad 0x0002000180000000,0x0000000000000000