From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53574)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UUfrL-0005yr-3N
	for qemu-devel@nongnu.org; Tue, 23 Apr 2013 12:14:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UUfqz-0004VP-Vj
	for qemu-devel@nongnu.org; Tue, 23 Apr 2013 12:14:22 -0400
Received: from mail-gh0-f174.google.com ([209.85.160.174]:53529)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UUfqz-0004V4-PZ
	for qemu-devel@nongnu.org; Tue, 23 Apr 2013 12:14:01 -0400
Received: by mail-gh0-f174.google.com with SMTP id r16so89944ghr.19
	for <qemu-devel@nongnu.org>; Tue, 23 Apr 2013 09:14:01 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5176B339.5070108@redhat.com>
Date: Tue, 23 Apr 2013 18:13:45 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1343401379-19495-1-git-send-email-pbonzini@redhat.com>
	<1343401379-19495-4-git-send-email-pbonzini@redhat.com>
	<51764A9C.8000508@siemens.com>
In-Reply-To: <51764A9C.8000508@siemens.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 03/32] lsi: use qdev_reset_all
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel@nongnu.org

Il 23/04/2013 10:47, Jan Kiszka ha scritto:
>> >          if (val & LSI_ISTAT0_SRST) {
>> > -            lsi_soft_reset(s);
>> > +            qdev_reset_all(&s->dev.qdev);
> What should ensure that all device resets are performed before the host
> reset? I'm asking as we just ran into the assert(!s->current) over
> 1.3.1. Or is there some patch from a later version missing (not seeing
> anything suspicious for lsi at least)?

qdev should, but it looks like it uses pre-order instead of post-order.

Paolo