From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46878)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UUgsv-0006xQ-3Y
	for qemu-devel@nongnu.org; Tue, 23 Apr 2013 13:20:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UUgsq-0004dd-A2
	for qemu-devel@nongnu.org; Tue, 23 Apr 2013 13:20:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55574)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UUgnc-0002Xf-4C
	for qemu-devel@nongnu.org; Tue, 23 Apr 2013 13:14:36 -0400
Message-ID: <5176C15E.9050106@redhat.com>
Date: Tue, 23 Apr 2013 19:14:06 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1366705795-24732-1-git-send-email-imammedo@redhat.com>
	<1366705795-24732-18-git-send-email-imammedo@redhat.com>
	<CAFEAcA-V4PhzhYG=6JoRq5P-MjHM5NCOCXvrV-aM4CB=isiOHw@mail.gmail.com>
In-Reply-To: <CAFEAcA-V4PhzhYG=6JoRq5P-MjHM5NCOCXvrV-aM4CB=isiOHw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 17/21] introduce
 memory_region_get_address() and use it in kvm/ioapic
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: gleb@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, blauwirbel@gmail.com, kraxel@redhat.com, quintela@redhat.com, armbru@redhat.com, yang.z.zhang@intel.com, ehabkost@redhat.com, stefano.stabellini@eu.citrix.com, aderumier@odiso.com, anthony.perard@citrix.com, alex.williamson@redhat.com, rth@twiddle.net, kwolf@redhat.com, aliguori@us.ibm.com, claudio.fontana@huawei.com, Igor Mammedov <imammedo@redhat.com>, afaerber@suse.de

Il 23/04/2013 19:06, Peter Maydell ha scritto:
>> >  /*
>> > + * memory_region_get_address: get current the address of a region
>> > + *
>> > + * Returns the absolute address of a region.
>> > + * May be used on regions that are currently part of a memory hierarchy.
>> > + *
>> > + * @mr: the region being queried
>> > + */
>> > +hwaddr memory_region_get_address(MemoryRegion *mr);
> This doesn't make sense as a memory API in my opinion. There's
> no such thing as the "absolute address of a MemoryRegion".

What about also passing an AddressSpace and stopping at the address
space's root?  Would that make more sense?

Paolo