From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <sw@weilnetz.de>, Blue Swirl <blauwirbel@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 2/2] win32: add readv/writev emulation
Date: Tue, 23 Apr 2013 20:22:51 +0200 [thread overview]
Message-ID: <5176D17B.7000000@redhat.com> (raw)
In-Reply-To: <5176C78F.4080206@weilnetz.de>
> Hi Paolo,
>
> your patch looks good, but maybe you could modify the signatures
> of readv, writev to match the Linux originals (missing const, use int):
>
> ssize_t readv(int fd, const struct iovec *iov, int iovcnt);
> ssize_t writev(int fd, const struct iovec *iov, int iovcnt);
>
> In an updated patch the tab characters could be replaced by a space
> to make checkpatch.pl happy.
Ok, I'll send it tomorrow. I'll make a pull request myself to
streamline the process in time for -rc0.
Paolo
prev parent reply other threads:[~2013-04-23 18:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 18:53 [Qemu-devel] [PATCH 0/2] fix win32 compilation Paolo Bonzini
2013-04-22 18:53 ` [Qemu-devel] [PATCH 1/2] add missing inclusions of config-host.h Paolo Bonzini
2013-04-22 18:53 ` [Qemu-devel] [PATCH 2/2] win32: add readv/writev emulation Paolo Bonzini
2013-04-23 17:40 ` Stefan Weil
2013-04-23 18:22 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5176D17B.7000000@redhat.com \
--to=pbonzini@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).