From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51876)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UUkMM-0000dD-Fp
	for qemu-devel@nongnu.org; Tue, 23 Apr 2013 17:02:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UUkMH-0000F1-LA
	for qemu-devel@nongnu.org; Tue, 23 Apr 2013 17:02:42 -0400
Received: from mail-qc0-x22b.google.com ([2607:f8b0:400d:c01::22b]:43304)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UUkMH-0000Ew-HA
	for qemu-devel@nongnu.org; Tue, 23 Apr 2013 17:02:37 -0400
Received: by mail-qc0-f171.google.com with SMTP id q2so567971qch.2
	for <qemu-devel@nongnu.org>; Tue, 23 Apr 2013 14:02:37 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5176F6DE.8080709@redhat.com>
Date: Tue, 23 Apr 2013 23:02:22 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1366705795-24732-1-git-send-email-imammedo@redhat.com>
	<1366705795-24732-18-git-send-email-imammedo@redhat.com>
	<CAFEAcA-V4PhzhYG=6JoRq5P-MjHM5NCOCXvrV-aM4CB=isiOHw@mail.gmail.com>
	<5176C15E.9050106@redhat.com>
	<CAFEAcA-WhjK8YbN-_FfA6i56JmTDQS=HsZXRz20AAYP6cpexjQ@mail.gmail.com>
	<5176C766.7070706@siemens.com>
	<CAFEAcA_J8Q02YSToG+GwpaWfxVxkufiLQLqV_DN0skPYodkADA@mail.gmail.com>
In-Reply-To: <CAFEAcA_J8Q02YSToG+GwpaWfxVxkufiLQLqV_DN0skPYodkADA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 17/21] introduce
 memory_region_get_address() and use it in kvm/ioapic
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "kwolf@redhat.com" <kwolf@redhat.com>, "aliguori@us.ibm.com" <aliguori@us.ibm.com>, "ehabkost@redhat.com" <ehabkost@redhat.com>, "gleb@redhat.com" <gleb@redhat.com>, "mst@redhat.com" <mst@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>, "quintela@redhat.com" <quintela@redhat.com>, claudio.fontana@huawei.com, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "aderumier@odiso.com" <aderumier@odiso.com>, "lcapitulino@redhat.com" <lcapitulino@redhat.com>, "blauwirbel@gmail.com" <blauwirbel@gmail.com>, "anthony.perard@citrix.com" <anthony.perard@citrix.com>, "alex.williamson@redhat.com" <alex.williamson@redhat.com>, "kraxel@redhat.com" <kraxel@redhat.com>, "yang.z.zhang@intel.com" <yang.z.zhang@intel.com>, "stefano.stabellini@eu.citrix.com" <stefano.stabellini@eu.citrix.com>, "armbru@redhat.com" <armbru@redhat.com>, "rth@twiddle.net" <rth@twiddle.net>

Il 23/04/2013 20:00, Peter Maydell ha scritto:
> For ARM we defer the mechanics of "tell the kernel where this memory
> region is" from the device implementation (hw/intc/arm_gic_kvm.c) to
> generic code in target-arm/kvm.c, which I personally think is a
> neat way to solve this problem.

Yes, it is.

> NB: I don't think we should call it memory_region_get_address()
> though -- that implies a non-existent parallel to the current
> memory_region_set_address().

Hmm, good point.  address_space_get_region_addr()?

Paolo