qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael R. Hines" <mrhines@linux.vnet.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	quintela@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com,
	Bulent Abali <abali@us.ibm.com>,
	Michael R Hines <mrhines@us.ibm.com>,
	Gokul B Kandiraju <gokul@us.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v5 00/12] rdma: migration support
Date: Tue, 23 Apr 2013 19:49:52 -0400	[thread overview]
Message-ID: <51771E20.1060602@linux.vnet.ibm.com> (raw)
In-Reply-To: <5176F90E.9080006@redhat.com>

On 04/23/2013 05:11 PM, Paolo Bonzini wrote:
> Il 23/04/2013 22:15, Michael R. Hines ha scritto:
>>> Also, don't be surprised if not everyone reviews the entire series;
>>> sometimes reviewers like myself focus only on the portion of the series
>>> that interacts with my current interests (I tend to review anything QMP,
>>> because I want to make sure the design will be sane for libvirt
>>> interaction, while overlooking things like migration internals because
>>> they are black box ops to libvirt if the interface was sane).
>>>
>> Yes, Paolo has done a fantastic job of reviewing the internals.
> But the internals have changed while I wasn't looking. :)
>
> I'm very close to giving my Reviewed-by, I would just prefer to have
> this last change reverted.
>
> Paolo
>

The only new change was QEMUFileOps "qemu_get_max_size()" (patch #4).

During this patch series, I stopped using my 40G hardware, but when I 
switched
back to my 40G hardware, I noticed that the max_size calculation was 
artificially
limiting the max throughput achievable by RDMA.

Everything else is the same as we agreed in previous versions.

- Michael

  reply	other threads:[~2013-04-23 23:50 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-23  1:55 [Qemu-devel] [PATCH v5 00/12] rdma: migration support mrhines
2013-04-23  1:55 ` [Qemu-devel] [PATCH v5 01/12] rdma: add documentation mrhines
2013-04-23  1:55 ` [Qemu-devel] [PATCH v5 02/12] rdma: export yield_until_fd_readable() mrhines
2013-04-23  1:55 ` [Qemu-devel] [PATCH v5 03/12] rdma: export throughput w/ MigrationStats QMP mrhines
2013-04-23  1:55 ` [Qemu-devel] [PATCH v5 04/12] rdma: introduce qemu_get_max_size() mrhines
2013-04-23  1:55 ` [Qemu-devel] [PATCH v5 05/12] rdma: introduce qemu_file_mode_is_not_valid() mrhines
2013-04-23  1:55 ` [Qemu-devel] [PATCH v5 06/12] rdma: export qemu_fflush() mrhines
2013-04-23  1:55 ` [Qemu-devel] [PATCH v5 07/12] rdma: introduce ram_handle_compressed() mrhines
2013-04-23  1:55 ` [Qemu-devel] [PATCH v5 08/12] rdma: introduce qemu_ram_foreach_block() mrhines
2013-04-23  1:55 ` [Qemu-devel] [PATCH v5 09/12] rdma: new QEMUFileOps hooks mrhines
2013-04-23  1:55 ` [Qemu-devel] [PATCH v5 10/12] rdma: introduce capability x-rdma-pin-all mrhines
2013-04-23  1:55 ` [Qemu-devel] [PATCH v5 11/12] rdma: core logic mrhines
2013-04-23 20:59   ` Paolo Bonzini
2013-04-23 23:53     ` Michael R. Hines
2013-04-24  6:38       ` Paolo Bonzini
2013-04-24 18:19         ` Michael R. Hines
2013-04-23 21:10   ` Paolo Bonzini
2013-04-24  0:01     ` Michael R. Hines
2013-04-23  1:55 ` [Qemu-devel] [PATCH v5 12/12] rdma: send pc.ram mrhines
2013-04-23 17:50 ` [Qemu-devel] [PATCH v5 00/12] rdma: migration support Anthony Liguori
2013-04-23 17:54   ` Michael R. Hines
2013-04-23 18:26     ` Anthony Liguori
2013-04-23 18:46       ` Michael R. Hines
2013-04-23 18:55         ` Anthony Liguori
2013-04-23 19:24       ` Eric Blake
2013-04-23 20:15         ` Michael R. Hines
2013-04-23 21:11           ` Eric Blake
2013-04-23 21:44             ` Anthony Liguori
2013-04-23 22:40               ` [Qemu-devel] contribution process [was: [PATCH v5 00/12] rdma: migration support] Eric Blake
2013-04-23 23:50                 ` Michael R. Hines
2013-04-23 23:50               ` [Qemu-devel] [PATCH v5 00/12] rdma: migration support Michael R. Hines
2013-04-23 21:11           ` Paolo Bonzini
2013-04-23 23:49             ` Michael R. Hines [this message]
2013-04-23 20:16       ` Michael R. Hines
  -- strict thread matches above, loose matches on Subject: below --
2013-04-21 21:17 mrhines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51771E20.1060602@linux.vnet.ibm.com \
    --to=mrhines@linux.vnet.ibm.com \
    --cc=abali@us.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=gokul@us.ibm.com \
    --cc=mrhines@us.ibm.com \
    --cc=owasserm@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).