From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUmyL-00028W-7F for qemu-devel@nongnu.org; Tue, 23 Apr 2013 19:50:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UUmyI-0007k5-1D for qemu-devel@nongnu.org; Tue, 23 Apr 2013 19:50:05 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:51324) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUmyH-0007iq-Tj for qemu-devel@nongnu.org; Tue, 23 Apr 2013 19:50:01 -0400 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 23 Apr 2013 19:49:57 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 509746E803A for ; Tue, 23 Apr 2013 19:49:51 -0400 (EDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3NNnrDA294666 for ; Tue, 23 Apr 2013 19:49:54 -0400 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3NNnrqH001399 for ; Tue, 23 Apr 2013 17:49:53 -0600 Message-ID: <51771E20.1060602@linux.vnet.ibm.com> Date: Tue, 23 Apr 2013 19:49:52 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1366682139-22122-1-git-send-email-mrhines@linux.vnet.ibm.com> <87li89dtmc.fsf@codemonkey.ws> <5176CADB.4000304@linux.vnet.ibm.com> <87k3ntm7co.fsf@codemonkey.ws> <5176DFFD.1040202@redhat.com> <5176EBE9.3080204@linux.vnet.ibm.com> <5176F90E.9080006@redhat.com> In-Reply-To: <5176F90E.9080006@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 00/12] rdma: migration support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Anthony Liguori , quintela@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, Bulent Abali , Michael R Hines , Gokul B Kandiraju On 04/23/2013 05:11 PM, Paolo Bonzini wrote: > Il 23/04/2013 22:15, Michael R. Hines ha scritto: >>> Also, don't be surprised if not everyone reviews the entire series; >>> sometimes reviewers like myself focus only on the portion of the series >>> that interacts with my current interests (I tend to review anything QMP, >>> because I want to make sure the design will be sane for libvirt >>> interaction, while overlooking things like migration internals because >>> they are black box ops to libvirt if the interface was sane). >>> >> Yes, Paolo has done a fantastic job of reviewing the internals. > But the internals have changed while I wasn't looking. :) > > I'm very close to giving my Reviewed-by, I would just prefer to have > this last change reverted. > > Paolo > The only new change was QEMUFileOps "qemu_get_max_size()" (patch #4). During this patch series, I stopped using my 40G hardware, but when I switched back to my 40G hardware, I noticed that the max_size calculation was artificially limiting the max throughput achievable by RDMA. Everything else is the same as we agreed in previous versions. - Michael