From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56699) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUw8X-0002Ri-06 for qemu-devel@nongnu.org; Wed, 24 Apr 2013 05:37:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UUw8R-0001kA-E5 for qemu-devel@nongnu.org; Wed, 24 Apr 2013 05:37:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58545) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUw8R-0001jp-6V for qemu-devel@nongnu.org; Wed, 24 Apr 2013 05:37:07 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3O9b6bY030491 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 24 Apr 2013 05:37:06 -0400 Message-ID: <5177A84A.9050602@redhat.com> Date: Wed, 24 Apr 2013 11:39:22 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <1366316544-1428-1-git-send-email-lersek@redhat.com> In-Reply-To: <1366316544-1428-1-git-send-email-lersek@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 0/7] publish etc/acpi/APIC in fw_cfg List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" On 04/18/13 22:22, Laszlo Ersek wrote: > v4: > - patches 1-6 are unchanged and carry Michael's ACK, > - patch 7 is rendered dependent on a new configure switch (default off) > [Michael Tsirkin]. > > v3: > - rebased to current master 24a6e7f4, > - added Michael's S-o-b to 6/7 [Eric Blake], > - added Dave Frodin's relicensing ACK to 7/7, originally sent to Michael > in private [Michael Tsirkin], > - slightly reworded 7/7's commit message where it credits Michael's > prototype [Eric Blake]. > > v2: > - address (1) in > : > > - rebase to Paolo's recent series > , > > - patch 2 is new, fixes style of function parameter references in a > comment [mst], > > - patch 6 is new, moves a macro definition [mst], > > - patch 7 should be structured more logically now, plus the commit > message has grown some bits related to licensing [mst]. > acpi_table_fill_hdr() is kept distinct from the -acpitable switch's > implementation on purpose, similarly to pc_acpi_install() in v1. > > - Tested APIC / DSDT / RSDT against contents saved from v1. > > v1 blurb: > > This series exports the MADT (APIC) ACPI table under the new > "etc/acpi/APIC" fw_cfg file. I sought to follow the requirements set > forth in [1], the new table is only visible in the patched/patched > case. I cross-tested { master, patched } qemu with { master, patched } > seabios (the APIC, DSDT and RSDT tables) using guest acpidump and > dmesg. > > The -acpitable command line option is purposely ignored based on the > last paragraph of [2]; the user isn't supposed to pass APIC with that > option. > > checkpatch.pl complains a little but (as last time) it's a false > alarm. > > The series is bisectable. > > [1] http://thread.gmane.org/gmane.comp.emulators.qemu/202005/focus=202072 > [2] http://thread.gmane.org/gmane.comp.bios.coreboot.seabios/5960/focus=6008 > > Laszlo Ersek (6): > refer to FWCfgState explicitly > acpi_table_install(): fix funcparam formatting in leading comment > hw/acpi: extract standard table headers as a standalone structure > hw/acpi: export default ACPI headers using the type just introduced > hw/acpi: export acpi_checksum() > hw/i386: build ACPI MADT (APIC) for fw_cfg clients > > Michael S. Tsirkin (1): > hw/i386/pc.c: move IO_APIC_DEFAULT_ADDRESS to include/hw/i386/apic.h > > configure | 12 ++++ > hw/i386/Makefile.objs | 1 + > hw/i386/acpi.h | 9 +++ > hw/i386/multiboot.h | 4 +- > include/hw/acpi/acpi.h | 15 +++++ > include/hw/i386/apic.h | 2 + > include/hw/i386/pc.h | 19 +++--- > include/hw/loader.h | 3 +- > hw/acpi/core.c | 91 ++++++++++++++------------- > hw/acpi/piix4.c | 2 +- > hw/core/loader.c | 2 +- > hw/i386/acpi.c | 159 ++++++++++++++++++++++++++++++++++++++++++++++++ > hw/i386/multiboot.c | 2 +- > hw/i386/pc.c | 49 +++++++++++---- > hw/i386/pc_piix.c | 2 +- > hw/sparc/sun4m.c | 6 +- > hw/sparc64/sun4u.c | 2 +- > 17 files changed, 303 insertions(+), 77 deletions(-) > create mode 100644 hw/i386/acpi.h > create mode 100644 hw/i386/acpi.c Ping... When may I expect reviews for this? (1) AIUI, - Michael hasn't acked this series, but he didn't NAK it either -- the two of us disagree on his most recent review, but that shouldn't be reason for others not to look at the series, - he's alrady cooking a series based on this one. (2) I'm aware that we're in soft freeze for 1.5 now. I'm just saying I won't touch the HPET or SRAT until this MADT series is sufficiently acked. I need to be able to trust the structure if I want it to carry the HPET and the SRAT too. (I don't insist in the slightest on (co-)owning this task, ie. there's no time pressure from my side. I'm just pointing out a dependency.) Thanks Laszlo