From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUy7u-00018l-TC for qemu-devel@nongnu.org; Wed, 24 Apr 2013 07:44:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UUy7t-0001js-Tp for qemu-devel@nongnu.org; Wed, 24 Apr 2013 07:44:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7275) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUy7t-0001ja-LO for qemu-devel@nongnu.org; Wed, 24 Apr 2013 07:44:41 -0400 Message-ID: <5177C5A1.4050109@redhat.com> Date: Wed, 24 Apr 2013 13:44:33 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1366798350-27068-1-git-send-email-lilei@linux.vnet.ibm.com> <1366798350-27068-3-git-send-email-lilei@linux.vnet.ibm.com> In-Reply-To: <1366798350-27068-3-git-send-email-lilei@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] vnc: Support for LED state extension List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li Cc: lagarcia@br.ibm.com, aliguori@us.ibm.com, qemu-devel@nongnu.org Hi, > + case VNC_ENCODING_LED_STATE: > + vs->features |= VNC_FEATURE_LED_STATE_MASK; > + break; I think it with the client supporting the led state extension it is probably a good idea to turn off the lock state sync logic in qemu's vnc server, i.e. add a "!(vs->features & VNC_FEATURE_LED_STATE_MASK)" check next to the lock_key_sync checks in do_key_event(). cheers, Gerd