From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55681) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV0Gg-0004Mf-3o for qemu-devel@nongnu.org; Wed, 24 Apr 2013 10:01:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UV0Ge-0001Xf-M8 for qemu-devel@nongnu.org; Wed, 24 Apr 2013 10:01:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25784) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV0Ge-0001XP-DS for qemu-devel@nongnu.org; Wed, 24 Apr 2013 10:01:52 -0400 Message-ID: <5177E5CE.6040101@redhat.com> Date: Wed, 24 Apr 2013 08:01:50 -0600 From: Eric Blake MIME-Version: 1.0 References: <1366807646-8473-1-git-send-email-akong@redhat.com> In-Reply-To: <1366807646-8473-1-git-send-email-akong@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2GBBITODVIMODAPDVQCWR" Subject: Re: [Qemu-devel] [RESEND PATCH 1/2] qapi: introduce strList and visit_type_strList() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: pbonzini@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, jyang@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2GBBITODVIMODAPDVQCWR Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/24/2013 06:47 AM, Amos Kong wrote: > Currently we can only use ['String'] to add string to a list, > it contains some additional JSON structure. > "multicast": [ > { > "str": "01:80:c2:00:00:21" > }, > { > "str": "00:00:00:00:00:00" > } > ] >=20 > This patch introdued strList, we can use ['str'] >=20 > "multicast": [ > "01:00:5e:00:00:01", > "33:33:ff:12:34:57" > ] >=20 > Signed-off-by: Amos Kong > --- > I used an _ugly_ "#ifndef" to limit it only be defined in qapi-types.h.= > do you have some suggestion to fix it? I'm not the maintainer, so you may still want to wait for a better suggestion. But since I personally don't mind the #ifdef if that's what it takes to get this to compile, and since I'd like to see the feature added, I'm fine giving: Reviewed-by: Eric Blake That said, I think the API in patch 2/2 is not quite right; and when you fix things there, you may not need this patch in the 1.5 timeframe... --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2GBBITODVIMODAPDVQCWR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRd+XOAAoJEKeha0olJ0NqeD8H/1edTlFhkyaCFSVE66+0php/ JmrbsmnvL3eVVydnG8O9Ld8g+tqeeg9Pd1FHBJFK2i5qqk/ZBfr2LbyF4fe1F0Ki GeJ/p9bxlcXINbJDkYKnWEdjNOltDj+54AZJCUaMCuW8W5q9DKY7OQybshZdssAi WzgoI1R+4H7oSmtknhb6kdTJqW08N/tcxynurX1mjK8VnNMR/gPYB+XXBuigqoRC H6kiwc65+ARnxS6Dy+s8tEwW1Ru61cjlR6WwtaMP7ZIYkaO8r5+S2ZOqUzEGvWZC 3uWH4daXUq4h+saqU3G8CRaTYNsvXAsdVbJ2OJASLl8V2HFFTgw2nmZ7LYLntQI= =8RUR -----END PGP SIGNATURE----- ------enig2GBBITODVIMODAPDVQCWR--