From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV15u-0002dJ-Mn for qemu-devel@nongnu.org; Wed, 24 Apr 2013 10:54:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UV15p-0005fM-QW for qemu-devel@nongnu.org; Wed, 24 Apr 2013 10:54:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62426) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV15p-0005fD-H1 for qemu-devel@nongnu.org; Wed, 24 Apr 2013 10:54:45 -0400 Message-ID: <5177F21A.6050406@redhat.com> Date: Wed, 24 Apr 2013 08:54:18 -0600 From: Eric Blake MIME-Version: 1.0 References: <1366798350-27068-1-git-send-email-lilei@linux.vnet.ibm.com> In-Reply-To: <1366798350-27068-1-git-send-email-lilei@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2CANRGGNCLSFSNLBJBGTK" Subject: Re: [Qemu-devel] [PATCH 0/3 v3] Support for LED state extension to Qemu VNC server List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li Cc: lagarcia@br.ibm.com, aliguori@us.ibm.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2CANRGGNCLSFSNLBJBGTK Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/24/2013 04:12 AM, Lei Li wrote: > Hi guys, >=20 > This patch series tries to add support for LED state > extension to Qemu VNC server. The proposal has been sent > few days ago as link below: >=20 > http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg01421.html >=20 > The previous version as link: >=20 > http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg03988.html >=20 > Pleae let me know if there is anything else need be improved. Can you fix your setup to include a series diffstat in your cover letter? I know that 'git send-email --cover-letter --annotate' does this; but I also know that's not the workflow everyone uses. I just updated http://wiki.qemu.org/Contribute/SubmitAPatch to mention that a cover letter diffstat is a useful review aid (I'd much rather check a 0/n letter to see what files are touched in summary, rather than opening n emails just to see if it touches any file I care about). I guess that means I'm asking for a bit of help in further updating the wiki to mention how to have git reliably include a cover letter diffstat, since asking for something without giving a recipe of how to accomplish it isn't very nice. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2CANRGGNCLSFSNLBJBGTK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRd/IaAAoJEKeha0olJ0NqCSEH/jZBCJnZ3Ab3L2GjDu4a5rlz HPkaLmQxSesqy2uEQBwR8+p/sJ2qOKTDiPohvXcKWIHfGPbO4sInqMPLYCIGzBLy 6hNYj0DCovUbTQH0krbI9cYL0+gyhE6Ocep18t6xGdptYR1DpiSmm3LZSLZYtaH5 GdEaM5BPx2Yl8wZ9O9avgK8JuNuxQLqCsIoLi7ZmkynpX77pePBg3RDX4TKdv10V e+6EnXZIGCTawXJip4VeHT2q4vrBflCgiCAvVmY31mu+F24TotBpuaF5NE5xj4Wy Whim2RemFF3jUaPee6kifEcGMr5HcuGrTp3OziY2UOH55/JU9fqkstY6E0/bokc= =uCBj -----END PGP SIGNATURE----- ------enig2CANRGGNCLSFSNLBJBGTK--