From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59113) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV1lh-000777-IH for qemu-devel@nongnu.org; Wed, 24 Apr 2013 11:38:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UV1lg-0005x5-44 for qemu-devel@nongnu.org; Wed, 24 Apr 2013 11:38:01 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48391 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV1lf-0005wq-UX for qemu-devel@nongnu.org; Wed, 24 Apr 2013 11:38:00 -0400 Message-ID: <5177FC53.1040300@suse.de> Date: Wed, 24 Apr 2013 17:37:55 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1366705795-24732-1-git-send-email-imammedo@redhat.com> <1366705795-24732-5-git-send-email-imammedo@redhat.com> In-Reply-To: <1366705795-24732-5-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 04/21] cpu: resume CPU from CPUClass.cpu_common_realizefn() when it is hot-plugged List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: kwolf@redhat.com, peter.maydell@linaro.org, aliguori@us.ibm.com, ehabkost@redhat.com, gleb@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, quintela@redhat.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, lcapitulino@redhat.com, blauwirbel@gmail.com, anthony.perard@citrix.com, alex.williamson@redhat.com, kraxel@redhat.com, yang.z.zhang@intel.com, pbonzini@redhat.com, stefano.stabellini@eu.citrix.com, armbru@redhat.com, rth@twiddle.net Am 23.04.2013 10:29, schrieb Igor Mammedov: > Signed-off-by: Igor Mammedov > --- > v2: > s/resume_vcpu/cpu_resume/ > v2: > * remove unnecessary now sysemu/cpus.h header > * move out introducing resume_vcpu() into a separate patch > --- > qom/cpu.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Thanks, applied to qom-cpu (rebased on introduction of cpu variable and aligning commit messages wrt realize): https://github.com/afaerber/qemu-cpu/commits/qom-cpu > diff --git a/qom/cpu.c b/qom/cpu.c > index 0c76712..abb20d0 100644 > --- a/qom/cpu.c > +++ b/qom/cpu.c > @@ -60,6 +60,7 @@ static void cpu_common_realizefn(DeviceState *dev, Er= ror **errp) > { > if (dev->hotplugged) { > cpu_synchronize_post_init(CPU(dev)); > + cpu_resume(CPU(dev)); Having introduced CPUState *cpu in a preceding patch, we can avoid the duplicate CPU() cast here. > } > } > =20 Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg