From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV2G2-0003tl-08 for qemu-devel@nongnu.org; Wed, 24 Apr 2013 12:09:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UV2Fw-00015X-Me for qemu-devel@nongnu.org; Wed, 24 Apr 2013 12:09:21 -0400 Received: from cantor2.suse.de ([195.135.220.15]:49725 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV2Fw-00015J-D4 for qemu-devel@nongnu.org; Wed, 24 Apr 2013 12:09:16 -0400 Message-ID: <517803A7.9010506@suse.de> Date: Wed, 24 Apr 2013 18:09:11 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1366705795-24732-11-git-send-email-imammedo@redhat.com> <1366734431-566-1-git-send-email-imammedo@redhat.com> <20130424175646.141a7da4@nial.usersys.redhat.com> <20130424160321.GL2900@otherpad.lan.raisama.net> In-Reply-To: <20130424160321.GL2900@otherpad.lan.raisama.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 10/21 DISGISED v6] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: kwolf@redhat.com, peter.maydell@linaro.org, aliguori@us.ibm.com, gleb@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, quintela@redhat.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, lcapitulino@redhat.com, blauwirbel@gmail.com, anthony.perard@citrix.com, alex.williamson@redhat.com, kraxel@redhat.com, pbonzini@redhat.com, yang.z.zhang@intel.com, Igor Mammedov , stefano.stabellini@eu.citrix.com, armbru@redhat.com, rth@twiddle.net Am 24.04.2013 18:03, schrieb Eduardo Habkost: > On Wed, Apr 24, 2013 at 05:56:46PM +0200, Igor Mammedov wrote: >> On Tue, 23 Apr 2013 18:27:11 +0200 >> Igor Mammedov wrote: >> >> NACK >> >> >> gpe_cpu.sts isn't need to be migrated, since CPU hotpluging during >> migration just doesn't work, since destination QEMU has to be starte= d >> with all present in guest CPUs (including hotplugged). >> i.e. src-qemu -smp 2,max-cpus=3D4; cpu-add id=3D2; dst-qemu -smp 3,m= ax-cpus=3D4 >> Destination QEMU will recreate the same gpe_cpu.sts=3Dt'111' bitmap = as >> on source by calling qemu_for_each_cpu(piix4_init_cpu_status, &s->gp= e_cpu); >> since it has been started with 3 CPUs on command line. >> >> tested on ping pong migration, It works as expected without gpe_cpu.st= s migrated. >> I'll post v7 to this thread shortly. >=20 > Are we going to make the cpu-add command fail in case it gets called > during migration? I would rather suggest to throw an Error* on realize, if this can be detected. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg