From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60602) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV5vZ-0008Ni-7R for qemu-devel@nongnu.org; Wed, 24 Apr 2013 16:04:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UV5vS-0006QD-Ro for qemu-devel@nongnu.org; Wed, 24 Apr 2013 16:04:29 -0400 Received: from cantor2.suse.de ([195.135.220.15]:59032 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV5vS-0006OA-J0 for qemu-devel@nongnu.org; Wed, 24 Apr 2013 16:04:22 -0400 Message-ID: <51783ABE.2070904@suse.de> Date: Wed, 24 Apr 2013 22:04:14 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1366705795-24732-1-git-send-email-imammedo@redhat.com> <1366705795-24732-7-git-send-email-imammedo@redhat.com> <51781074.3070603@suse.de> In-Reply-To: <51781074.3070603@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 06/21] target-i386: pc: update rtc_cmos on CPU hot-plug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: kwolf@redhat.com, peter.maydell@linaro.org, aliguori@us.ibm.com, ehabkost@redhat.com, gleb@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, quintela@redhat.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, lcapitulino@redhat.com, blauwirbel@gmail.com, yang.z.zhang@intel.com, alex.williamson@redhat.com, kraxel@redhat.com, anthony.perard@citrix.com, pbonzini@redhat.com, armbru@redhat.com, stefano.stabellini@eu.citrix.com, rth@twiddle.net Am 24.04.2013 19:03, schrieb Andreas F=E4rber: > Am 23.04.2013 10:29, schrieb Igor Mammedov: >> it provides updated currently available CPUs count to BIOS on reboot >> >> Signed-off-by: Igor Mammedov >> --- >> v2: >> * reorder fields in rtc_cpu_hotplug_arg, make cpu_added_notifier fir= st. >> * rebase on top of "mc146818rtc: QOM'ify" and use QOM style cast >> --- >> hw/i386/pc.c | 20 ++++++++++++++++++++ >> hw/timer/mc146818rtc.c | 7 +++++++ >> include/hw/timer/mc146818rtc.h | 1 + >> 3 files changed, 28 insertions(+), 0 deletions(-) >> >> diff --git a/hw/i386/pc.c b/hw/i386/pc.c >> index 0d6e72b..bbc3bea 100644 >> --- a/hw/i386/pc.c >> +++ b/hw/i386/pc.c >> @@ -338,6 +338,21 @@ static void pc_cmos_init_late(void *opaque) >> qemu_unregister_reset(pc_cmos_init_late, opaque); >> } >> =20 >> +typedef struct rtc_cpu_hotplug_arg { >> + Notifier cpu_added_notifier; >> + ISADevice *rtc_state; >> +} rtc_cpu_hotplug_arg; >=20 > RTCCPUHotplugArg? Igor agreed to this variant on IRC. Thanks, applied to qom-cpu: https://github.com/afaerber/qemu-cpu/commits/qom-cpu Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg