From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV5yj-0001SD-OP for qemu-devel@nongnu.org; Wed, 24 Apr 2013 16:07:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UV5ye-0007qc-UB for qemu-devel@nongnu.org; Wed, 24 Apr 2013 16:07:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10690) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV5ye-0007qN-LE for qemu-devel@nongnu.org; Wed, 24 Apr 2013 16:07:40 -0400 Message-ID: <51783B20.4070407@redhat.com> Date: Wed, 24 Apr 2013 14:05:52 -0600 From: Eric Blake MIME-Version: 1.0 References: <8b6851c3a59103d7dd55ae400be90e6d7431ab0b.1366817130.git.phrdina@redhat.com> In-Reply-To: <8b6851c3a59103d7dd55ae400be90e6d7431ab0b.1366817130.git.phrdina@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2JTGAGHAFSMODFPECEEIU" Subject: Re: [Qemu-devel] [PATCH v2 02/12] block: update error reporting for bdrv_snapshot_delete() and related functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Hrdina Cc: kwolf@redhat.com, xiawenc@linux.vnet.ibm.com, lcapitulino@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2JTGAGHAFSMODFPECEEIU Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/24/2013 09:32 AM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > block.c | 21 +++++++++++++-------- > block/qcow2-snapshot.c | 19 +++++++++++++------ > block/qcow2.h | 4 +++- > block/rbd.c | 10 +++++++--- > block/sheepdog.c | 6 ++++-- > include/block/block.h | 4 +++- > include/block/block_int.h | 4 +++- > qemu-img.c | 8 +++----- > savevm.c | 32 ++++++++++++++++---------------- > 9 files changed, 65 insertions(+), 43 deletions(-) >=20 > +++ b/block/sheepdog.c > @@ -1937,10 +1937,12 @@ out: > return ret; > } > =20 > -static int sd_snapshot_delete(BlockDriverState *bs, const char *snapsh= ot_id) > +static void sd_snapshot_delete(BlockDriverState *bs, > + const char *snapshot_id, > + Error **errp) > { > /* FIXME: Delete specified snapshot id. */ > - return 0; > + error_setg(errp, "Deleting snapshot is not supported"); Commit message should mention this bug fix. But the code looked okay to me, so: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2JTGAGHAFSMODFPECEEIU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJReDsgAAoJEKeha0olJ0Nq5PAH/iRmQxMdDXjyWLZ9l+2TwHfb X3ZTc5ZS12HP6tHElVco8zRc4VGzx1OjAlmQ7Q8F7FexWycCKy4PX3wRLtWimsE1 JcskESsW5fbyPj/w3pnvt69eMZ5YRt+GzopnmoEdvZ0qwCzKi4764U4Jm9YBXN2Y YUC6iI7I/FX+eKIryQ8IlOvy2MOdFU8egpGB0oSwKD7R4Sn0+fjzgIzQ/yO7X+FB FihwVmW98mtSvnbHf+wqRJbUxZPqqm4xnpXYAc703rxORlmSiyb7DooGZpgVFKZX 1rNY2tAhU3/VDMzQp5rGVvRsvzGfD0/arTpbq81Qr+HCllw+pTME9Nn9k1JZ7FY= =FEPc -----END PGP SIGNATURE----- ------enig2JTGAGHAFSMODFPECEEIU--