From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV9Xa-0005h9-9u for qemu-devel@nongnu.org; Wed, 24 Apr 2013 19:56:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UV9XU-0000H1-K7 for qemu-devel@nongnu.org; Wed, 24 Apr 2013 19:55:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43105) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV9XU-0000Gt-9M for qemu-devel@nongnu.org; Wed, 24 Apr 2013 19:55:52 -0400 Message-ID: <51787105.4050004@redhat.com> Date: Wed, 24 Apr 2013 17:55:49 -0600 From: Eric Blake MIME-Version: 1.0 References: <1366807646-8473-2-git-send-email-akong@redhat.com> <1366824804-24532-1-git-send-email-akong@redhat.com> <20130424142020.4e6a54a1@redhat.com> <517834DC.1040602@redhat.com> In-Reply-To: <517834DC.1040602@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2LSLMNAQBVWUPWCADRBMX" Subject: Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aliguori@us.ibm.com, Amos Kong , qemu-devel@nongnu.org, jyang@redhat.com, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2LSLMNAQBVWUPWCADRBMX Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/24/2013 01:39 PM, Eric Blake wrote: > On 04/24/2013 12:20 PM, Luiz Capitulino wrote: >> On Thu, 25 Apr 2013 01:33:24 +0800 >> Amos Kong wrote: >> >>> Libvirt has no way to probe if an option or property is supported, >>> This patch introdues a new qmp command to query configuration schema >>> information. hmp command isn't added because it's not needed. >>> >>> +## >>> +# @ConfigParamType: >>> +# >>> +# JSON representation of values of QEMUOptionParType, may grow in fu= ture >=20 > I see why you used this text (it's straight copy-and-paste from my emai= l > suggestion); but it's rather geared towards someone that cares about th= e > internals of qemu. On the other hand, qapi-schema is the public > interface that should tell you how to interact with qemu without having= > to open include/qemu/option.h or even know about the C type > QEMUOptionParType in the first place. Also, we've never mentioned that= > enums are subject to future growth elsewhere - it's kind of implicit. = I > think the following would be better text (and sorry for leading you in= > the wrong direction; in my mail, I was trying to justify WHY I suggeste= d > the type, not HOW it should be documented). That said, while the public document need not refer to the C api, you SHOULD patch include/qemu/option.h to document that any additions to the C API should be reflected back into the public QMP type name. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2LSLMNAQBVWUPWCADRBMX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJReHEFAAoJEKeha0olJ0NqtQMH/3004p1BEuUFb32I6/ra2MgG KHj/9qOD10NNUqa4jheLMLTB7pjoCJwNZ7ZBngCkTVrWtqwQ9FHnEfNnCfuZi6pM dgfXKvf5uejnrRT7tQuSkpuwN3DDs+NVF55pB3lscKAJqM8IP6rTZpBjWPEoSEtV kSz9IH8TlBPpG+njgq7ggsD8ee0YSfxjfyQFJgg6YPrvvh7EG8d3YXA5dKYIALo2 SFKkrvp06prALwNHe6yHy4PrgmW5yW5LsMnSEuhnIbkEf24bQUR3tbi7gV9b2dlL 8N+ZjAxEo1DY8K68VNGRDCjEVek1ibMcdO9C9yCrOY/eCHb5PMP+SvM+hjDScGE= =kJYn -----END PGP SIGNATURE----- ------enig2LSLMNAQBVWUPWCADRBMX--