From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55021) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVBDR-0000oN-B1 for qemu-devel@nongnu.org; Wed, 24 Apr 2013 21:43:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVBDM-0001HO-LA for qemu-devel@nongnu.org; Wed, 24 Apr 2013 21:43:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38576) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVBDM-0001HK-C8 for qemu-devel@nongnu.org; Wed, 24 Apr 2013 21:43:12 -0400 Message-ID: <51788A2E.6010600@redhat.com> Date: Wed, 24 Apr 2013 19:43:10 -0600 From: Eric Blake MIME-Version: 1.0 References: <1366807646-8473-2-git-send-email-akong@redhat.com> <1366824804-24532-1-git-send-email-akong@redhat.com> <20130424142020.4e6a54a1@redhat.com> <20130425011451.GB3230@t430s.nay.redhat.com> In-Reply-To: <20130425011451.GB3230@t430s.nay.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2SCTDWHRWQIULKIVLWSRB" Subject: Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, jyang@redhat.com, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2SCTDWHRWQIULKIVLWSRB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/24/2013 07:14 PM, Amos Kong wrote: >>> +## >>> +{'command': 'query-config-schema', 'data': {'*option': 'str'}, >> >> Please, let's not make option optional. It makes the code slightly mor= e >> complex for no good reason. >=20 > For the human, if they don't know the detail name of one option, they j= ust > list all the options, then find the useful one. >=20 > Not sure the use-case of full list for libvirt. Osier? I think I already answered that - having the whole list (single QMP call) is more efficient than calling multiple times per command we are interested in. Also, most other query-* commands do NOT filter; having the 'option' argument introduces filtering. It's up to Luiz whether we leave it as is, or omit '*option' for now and save filtering for later, but I'd rather not have mandatory 'option' as then you have to know in advance which command line options you care about. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2SCTDWHRWQIULKIVLWSRB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJReIouAAoJEKeha0olJ0Nq0hMH/i/nLw9zknRZ6LgN6lkCahA5 rT7n9HIpz4geApdcf+thWdzQxG8z/00PwpE+uQdh0KPToGanuXR/GeV5qq+Hwa5e bN3NNYXBeTsJYIWNu0+I5/Xge0RjGNNy77GjoJ+Xo4S6zNavjiZfQ0fLYrB+4aez aL7EcJSBam1xISwu3ZmpY3/Wh97aVl4Fxwj4VXrFOJQfROeVTZ1XtrtvI7HJIMcd zyaT+7ieI5nuhJ/nt4fi3jQE2EfVrro4k4cGfnIUXLU+IAQ/uZmNkUj33Kq59578 SL8NiZiqqHXgwqtmyOLAXPHhvuetX+LvnZv/VDFau8Gp8QbmX6bGdkPkvpBtA4o= =2q71 -----END PGP SIGNATURE----- ------enig2SCTDWHRWQIULKIVLWSRB--