From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVBt6-0000Qp-EL for qemu-devel@nongnu.org; Wed, 24 Apr 2013 22:26:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVBt1-0005kc-L6 for qemu-devel@nongnu.org; Wed, 24 Apr 2013 22:26:20 -0400 Received: from e28smtp01.in.ibm.com ([122.248.162.1]:36940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVBt1-0005kV-3e for qemu-devel@nongnu.org; Wed, 24 Apr 2013 22:26:15 -0400 Received: from /spool/local by e28smtp01.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 25 Apr 2013 07:51:12 +0530 Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id C79A8394002D for ; Thu, 25 Apr 2013 07:56:05 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3P2PvO410092546 for ; Thu, 25 Apr 2013 07:55:57 +0530 Received: from d28av02.in.ibm.com (loopback [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3P2Q24o023483 for ; Thu, 25 Apr 2013 12:26:02 +1000 Message-ID: <5178942C.8090805@linux.vnet.ibm.com> Date: Thu, 25 Apr 2013 10:25:48 +0800 From: Lei Li MIME-Version: 1.0 References: <1366798350-27068-1-git-send-email-lilei@linux.vnet.ibm.com> <1366798350-27068-4-git-send-email-lilei@linux.vnet.ibm.com> <5177F2DD.4020402@redhat.com> In-Reply-To: <5177F2DD.4020402@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] doc: document the Pseudo-encoding of LED state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: lagarcia@br.ibm.com, aliguori@us.ibm.com, qemu-devel@nongnu.org On 04/24/2013 10:57 PM, Eric Blake wrote: > On 04/24/2013 04:12 AM, Lei Li wrote: >> Signed-off-by: Lei Li >> --- >> docs/vnc-ledstate-Pseudo-encoding.txt | 40 +++++++++++++++++++++++++++++++++ >> 1 files changed, 40 insertions(+), 0 deletions(-) >> create mode 100644 docs/vnc-ledstate-Pseudo-encoding.txt >> >> + >> +The Pseudo-encoding number for LED state defined as: >> + >> +======= =============================================================== >> +Number Name >> +======= =============================================================== >> +-261 'LED state Pseudo-encoding'_ > Is the trailing _ intentional? Yes, add this trailing '_' to indicate that this is a quoted context and you can locate its section somewhere. I saw this style used in RFB protocol, but it's not necessary. I'd get rid of it if you don't like it. :) > >> +======= =============================================================== >> + >> +LED state Pseudo-enconding > s/enconding/encoding/ Sure. >> +-------------------------- >> + >> +The LED state Pseudo-encoding describes the encoding of LED state which >> +consists of 3 bits, each bit represents the Caps, Num, and Scroll lock >> +key respectively. '1' indicates that the LED should be on and '0' should >> +be off. > Which bit is which? Is bit 0 the Caps lock LED? Caps lock key is represented as '100', and Scroll lock key is represented as '001'. Sorry, I should describe it more clearly. Or maybe I should include the example of the encodings defined? > -- Lei