From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVCMF-0002Cv-N2 for qemu-devel@nongnu.org; Wed, 24 Apr 2013 22:56:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVCME-0006rc-GX for qemu-devel@nongnu.org; Wed, 24 Apr 2013 22:56:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29165) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVCME-0006rV-8l for qemu-devel@nongnu.org; Wed, 24 Apr 2013 22:56:26 -0400 Message-ID: <51789B53.2060705@redhat.com> Date: Wed, 24 Apr 2013 20:56:19 -0600 From: Eric Blake MIME-Version: 1.0 References: <1366798350-27068-1-git-send-email-lilei@linux.vnet.ibm.com> <1366798350-27068-4-git-send-email-lilei@linux.vnet.ibm.com> <5177F2DD.4020402@redhat.com> <5178942C.8090805@linux.vnet.ibm.com> In-Reply-To: <5178942C.8090805@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2LMGOSJXKVCMQGCXRQIEF" Subject: Re: [Qemu-devel] [PATCH 3/3] doc: document the Pseudo-encoding of LED state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li Cc: lagarcia@br.ibm.com, aliguori@us.ibm.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2LMGOSJXKVCMQGCXRQIEF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/24/2013 08:25 PM, Lei Li wrote: > On 04/24/2013 10:57 PM, Eric Blake wrote: >> On 04/24/2013 04:12 AM, Lei Li wrote: >>> Signed-off-by: Lei Li >>> --- >>> docs/vnc-ledstate-Pseudo-encoding.txt | 40 >>> +++++++++++++++++++++++++++++++++ >>> 1 files changed, 40 insertions(+), 0 deletions(-) >>> create mode 100644 docs/vnc-ledstate-Pseudo-encoding.txt >>> >>> + >>> +The Pseudo-encoding number for LED state defined as: >>> + >>> +=3D=3D=3D=3D=3D=3D=3D =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>> +Number Name >>> +=3D=3D=3D=3D=3D=3D=3D =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>> +-261 'LED state Pseudo-encoding'_ >> Is the trailing _ intentional? >=20 > Yes, add this trailing '_' to indicate that this is a quoted context an= d > you can > locate its section somewhere. > I saw this style used in RFB protocol, but it's not necessary. I'd get > rid of it > if you don't like it. :) I didn't read the RFB protocol; if you are being consistent with a parent document that you are extending, then by all means use the same conventions. >> Which bit is which? Is bit 0 the Caps lock LED? >=20 > Caps lock key is represented as '100', and Scroll lock key is > represented as '001'. > Sorry, I should describe it more clearly. Yep, especially since your choice of encoding was opposite to mine. A good protocol should be easy to implement. I don't care which order the bits go in, as long as everyone treats the same bit as caps lock based on good docs. > Or maybe I should include the example of the encodings defined? In my opinion, adding an example will never hurt :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2LMGOSJXKVCMQGCXRQIEF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJReJtTAAoJEKeha0olJ0Nqf8YIAIhiqItUUfuHGiM63yx5uQ1U 40/Ic4R2YpgJODzLZzGr99s4fJx0HTAbe8orMp8p6OcKnLVc+eoWnuKvkk/m7D+X 5D5qwguFwn7x3DIVF5MJbV9h5mHAqHQE5F1qO0A+KKfrc0sk9PhWQJAZIelwaAS6 2gZ+809coPosauKsSqcAuJlws8YoPgVbNDJ9jaGTnCXXSEwavRl2V6vwefwvbhci LCpJLNQuMOXkoh1UvPmMPKxGXEolqBFnqaGz5DdB2MjRvb6WWsZb7YpRcf1MqbGc +OtKpcVZhaeGVOns0pxE82zJJ07CzjiUrNGocPNvMn0yx4+fDVFvbxUbggRF07w= =jArZ -----END PGP SIGNATURE----- ------enig2LMGOSJXKVCMQGCXRQIEF--