From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55348) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVDYm-0005u4-Aw for qemu-devel@nongnu.org; Thu, 25 Apr 2013 00:13:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVDYe-0005a3-Qs for qemu-devel@nongnu.org; Thu, 25 Apr 2013 00:13:28 -0400 Received: from mail-pb0-x22b.google.com ([2607:f8b0:400e:c01::22b]:46636) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVDYe-0005Zs-KZ for qemu-devel@nongnu.org; Thu, 25 Apr 2013 00:13:20 -0400 Received: by mail-pb0-f43.google.com with SMTP id md4so662014pbc.16 for ; Wed, 24 Apr 2013 21:13:20 -0700 (PDT) Message-ID: <5178AD4A.6050306@gmail.com> Date: Thu, 25 Apr 2013 12:12:58 +0800 From: Liu Yuan MIME-Version: 1.0 References: <1366822079-6582-1-git-send-email-namei.unix@gmail.com> In-Reply-To: <1366822079-6582-1-git-send-email-namei.unix@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] sheepdog: fix loadvm operation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sheepdog@lists.wpkg.org Cc: Kevin Wolf , Stefan Hajnoczi , qemu-devel@nongnu.org, MORITA Kazutaka On 04/25/2013 12:47 AM, Liu Yuan wrote: > - don't break old behavior if we boot up on the snapshot by using s->reverted > to indicate if we delete working VDI successfully If we implement 'boot from snapshot' == loadvm snapshot, we don't need s->reverted. What do you think, Kazutaka? With this idea, qemu -hda sheepdog:test:id will be virtually the same as qemu -hda sheepdog:test -loadvm id. I don't understand the usecase for snapshting current workding VDI and then restore to the specified snapshot. Thanks, Yuan