From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVG8p-0001KF-On for qemu-devel@nongnu.org; Thu, 25 Apr 2013 02:58:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVG8l-0005Dg-5G for qemu-devel@nongnu.org; Thu, 25 Apr 2013 02:58:51 -0400 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:53497) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVG8k-0005DU-KV for qemu-devel@nongnu.org; Thu, 25 Apr 2013 02:58:47 -0400 Received: from /spool/local by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 25 Apr 2013 16:49:14 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 433162CE804D for ; Thu, 25 Apr 2013 16:58:40 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3P6j4Ca12255438 for ; Thu, 25 Apr 2013 16:45:04 +1000 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3P6wdOh001989 for ; Thu, 25 Apr 2013 16:58:39 +1000 Message-ID: <5178D407.3010900@linux.vnet.ibm.com> Date: Thu, 25 Apr 2013 14:58:15 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <2d4c5e75a5fa710d73fa4ffae03f4c143ba66519.1366817130.git.phrdina@redhat.com> <517862AC.3030500@redhat.com> In-Reply-To: <517862AC.3030500@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 04/12] qapi: Convert delvm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: lcapitulino@redhat.com, kwolf@redhat.com, Pavel Hrdina , qemu-devel@nongnu.org, armbru@redhat.com >> + char buf[256]; > > I know this fixed-size buffer is just a copy-and-paste from other code > that displays snapshot information, but I really hate it. On the other > hand, I can tolerate if we have it as an intermediate step between two > series that both land in the same release. > > If your series goes in first, Wenchao's series that cleans up the > fixed-size buffer will need to be rebased to tweak this additional spot. > If Wenchao's patches go in first, then you will have a bit of rebase > work to do. Since we are already deferring this series into 1.6, I > think it would be nice to post a unified series of the best of both > authors, rather than continuing to waffle on what should go in first. That would be a very long serial, taking time to rebase for any code change in it, that is why I haven't consider it before. > [And if I keep saying that often enough, I may end up getting my hands > dirty and becoming the person that posts such a unified patch, although Pls don't, I guess it would not be a good experience working in a long serial which may need modification later. > generally I don't like forcefully taking over someone else's initial work.] > My serial serves mainly for block image's info querying, different with Pavel, one serial fixing all is not easy to make. Instead, I'll send out small serial change the common part: 1 better bdrv_snapshot_find(). 2 hmp/qemu-img dumping info code(). Then we rebase on it, as two serial, do you think it is OK? >> +++ b/qapi-schema.json > -- Best Regards Wenchao Xia