From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57295) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVLuG-0000qQ-5I for qemu-devel@nongnu.org; Thu, 25 Apr 2013 09:08:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVLuB-0000eh-Ko for qemu-devel@nongnu.org; Thu, 25 Apr 2013 09:08:12 -0400 Received: from mail-pd0-f170.google.com ([209.85.192.170]:56039) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVLuB-0000eW-Ee for qemu-devel@nongnu.org; Thu, 25 Apr 2013 09:08:07 -0400 Received: by mail-pd0-f170.google.com with SMTP id 10so1799749pdi.29 for ; Thu, 25 Apr 2013 06:08:06 -0700 (PDT) Message-ID: <51792AB1.7040301@gmail.com> Date: Thu, 25 Apr 2013 21:08:01 +0800 From: Liu Yuan MIME-Version: 1.0 References: <1366886263-21263-1-git-send-email-morita.kazutaka@lab.ntt.co.jp> <1366886263-21263-4-git-send-email-morita.kazutaka@lab.ntt.co.jp> In-Reply-To: <1366886263-21263-4-git-send-email-morita.kazutaka@lab.ntt.co.jp> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [sheepdog] [PATCH 3/3] sheepdog: resend write requests when SD_RES_READONLY is received List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: MORITA Kazutaka Cc: kwolf@redhat.com, sheepdog@lists.wpkg.org, qemu-devel@nongnu.org, stefanha@redhat.com On 04/25/2013 06:37 PM, MORITA Kazutaka wrote: > +/* update inode with the latest state */ > +static int coroutine_fn reload_vdi_object(BDRVSheepdogState *s) I'd suggest function name as 'reload_inode(BDRVSheepdogState *s, tag, snapid)', then sd_create_branch and sd_snapshot_goto can make use of this function. With this change, it would be conflicted to my patch series applied to Stefan's block tree + Fix loadvm patch. So it would be better you can develop this patch set against Stefan's block tree + my fix loadvm patch. Others looks good to me. Thanks, Yuan