From: Eric Blake <eblake@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: kwolf@redhat.com, phrdina@redhat.com, qemu-devel@nongnu.org,
armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/2] block: move bdrv_dev_change_media_cb() to callers that really need it
Date: Thu, 25 Apr 2013 07:59:02 -0600 [thread overview]
Message-ID: <517936A6.6040804@redhat.com> (raw)
In-Reply-To: <1366393639-20651-3-git-send-email-lcapitulino@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]
On 04/19/2013 11:47 AM, Luiz Capitulino wrote:
> Commit 9ca111544c64b5abed2e79cf52e19a8f227b347b moved the call to
> bdrv_dev_change_media_cb() outside the media check in bdrv_close(),
> this added a regression where spurious DEVICE_TRAY_MOVED events
> are emitted at shutdown.
Libvirt can tolerate the extra events, but I agree that targeting 1.5 as
the release to clean this back up is reasonable.
>
> To fix that this commit moves the bdrv_dev_change_media_cb() calls
> to the callers that really need to report a media change, which
> are eject_device() and do_drive_del(). This fixes the problem
> commit 9ca1115 intended to fix, plus the spurious events.
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
> block.c | 2 --
> blockdev.c | 2 ++
> 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-04-25 13:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 17:47 [Qemu-devel] [PATCH 0/2] block: fix spurious DEVICE_TRAY_MOVED events on shutdown Luiz Capitulino
2013-04-19 17:47 ` [Qemu-devel] [PATCH 1/2] block: make bdrv_dev_change_media_cb() public Luiz Capitulino
2013-04-25 13:57 ` Eric Blake
2013-04-19 17:47 ` [Qemu-devel] [PATCH 2/2] block: move bdrv_dev_change_media_cb() to callers that really need it Luiz Capitulino
2013-04-25 13:59 ` Eric Blake [this message]
2013-04-25 18:18 ` Markus Armbruster
2013-04-25 21:16 ` Luiz Capitulino
2013-04-26 11:35 ` Markus Armbruster
2013-05-21 15:54 ` Pavel Hrdina
2013-04-22 13:53 ` [Qemu-devel] [PATCH 0/2] block: fix spurious DEVICE_TRAY_MOVED events on shutdown Stefan Hajnoczi
2013-04-25 13:51 ` Luiz Capitulino
2013-04-25 14:29 ` Stefan Hajnoczi
2013-04-25 14:31 ` Luiz Capitulino
2013-05-17 14:23 ` Pavel Hrdina
2013-05-21 12:26 ` Luiz Capitulino
2013-05-21 12:56 ` Pavel Hrdina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517936A6.6040804@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=phrdina@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).