From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46060) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVMhb-0003li-4p for qemu-devel@nongnu.org; Thu, 25 Apr 2013 09:59:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVMhU-00024V-Gg for qemu-devel@nongnu.org; Thu, 25 Apr 2013 09:59:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVMhU-00023y-5Y for qemu-devel@nongnu.org; Thu, 25 Apr 2013 09:59:04 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3PDx3uH021475 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 25 Apr 2013 09:59:03 -0400 Message-ID: <517936A6.6040804@redhat.com> Date: Thu, 25 Apr 2013 07:59:02 -0600 From: Eric Blake MIME-Version: 1.0 References: <1366393639-20651-1-git-send-email-lcapitulino@redhat.com> <1366393639-20651-3-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1366393639-20651-3-git-send-email-lcapitulino@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2BCAKUOHRFTCDLUNWDIXQ" Subject: Re: [Qemu-devel] [PATCH 2/2] block: move bdrv_dev_change_media_cb() to callers that really need it List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, phrdina@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2BCAKUOHRFTCDLUNWDIXQ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/19/2013 11:47 AM, Luiz Capitulino wrote: > Commit 9ca111544c64b5abed2e79cf52e19a8f227b347b moved the call to > bdrv_dev_change_media_cb() outside the media check in bdrv_close(), > this added a regression where spurious DEVICE_TRAY_MOVED events > are emitted at shutdown. Libvirt can tolerate the extra events, but I agree that targeting 1.5 as the release to clean this back up is reasonable. >=20 > To fix that this commit moves the bdrv_dev_change_media_cb() calls > to the callers that really need to report a media change, which > are eject_device() and do_drive_del(). This fixes the problem > commit 9ca1115 intended to fix, plus the spurious events. >=20 > Signed-off-by: Luiz Capitulino > --- > block.c | 2 -- > blockdev.c | 2 ++ > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2BCAKUOHRFTCDLUNWDIXQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJReTamAAoJEKeha0olJ0Nqt6kH/RZjUU28bc35SJ5iwW+MEsDd xtoNtcsKtVMijIPqtJ4xbPCw/mhz8971nes4yQQu+r27N08tiISNBOje82MOMtpV 2kusTQmk3ZQgQr5nPwbWRbTwxQr0a6T3T/tuTXZpNMdcXIPFw5+FXnm2aauwYKa9 QfV9izFOQvFrIO6jLjqkapZq86tGs+LbhzsHiZEAEwpV/FYInMigYyxR/BKaDZDo Iaq4vTNMoM+goz45TFdscOJwPFvWgTCJcQu3Nk2uV+8r9YofFGDet2nMft5Kr9TA GlezLzLUD+M1rqQI708/zcfJg0YyMPKo75UG6XVsmPLaNDeswgAha5+bLDTCuT8= =gd7i -----END PGP SIGNATURE----- ------enig2BCAKUOHRFTCDLUNWDIXQ--