From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55949)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UVdt6-0002ov-EP
	for qemu-devel@nongnu.org; Fri, 26 Apr 2013 04:20:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UVdt1-0008Av-PX
	for qemu-devel@nongnu.org; Fri, 26 Apr 2013 04:20:12 -0400
Received: from mail-qe0-f47.google.com ([209.85.128.47]:40881)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UVdt1-0008Ao-M6
	for qemu-devel@nongnu.org; Fri, 26 Apr 2013 04:20:07 -0400
Received: by mail-qe0-f47.google.com with SMTP id x7so1818009qeu.34
	for <qemu-devel@nongnu.org>; Fri, 26 Apr 2013 01:20:07 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <517A38AB.6030600@redhat.com>
Date: Fri, 26 Apr 2013 10:19:55 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1366956141-2066-1-git-send-email-david@gibson.dropbear.id.au>
	<1366956141-2066-2-git-send-email-david@gibson.dropbear.id.au>
In-Reply-To: <1366956141-2066-2-git-send-email-david@gibson.dropbear.id.au>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/4] Fix vmw_pvscsi.c for iommu support
	changes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: aik@ozlabs.ru, alex.williamson@redhat.com, qemu-devel@nongnu.org

Il 26/04/2013 08:02, David Gibson ha scritto:
> vmw_pvscsi.c directly calls pci_dma_sglist_init() instead of using the
> helper for PCI devices, which means it was broken by Paolo Bonzini's
> recent addition of iommu support to the memory API.  This fixes it.
> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
>  hw/scsi/vmw_pvscsi.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c
> index 4b4a58f..68c8d58 100644
> --- a/hw/scsi/vmw_pvscsi.c
> +++ b/hw/scsi/vmw_pvscsi.c
> @@ -617,7 +617,7 @@ pvscsi_build_sglist(PVSCSIState *s, PVSCSIRequest *r)
>  {
>      PCIDevice *d = PCI_DEVICE(s);
>  
> -    qemu_sglist_init(&r->sgl, 1, pci_dma_context(d));
> +    pci_dma_sglist_init(&r->sgl, d, 1);
>      if (r->req.flags & PVSCSI_FLAG_CMD_WITH_SG_LIST) {
>          pvscsi_convert_sglist(r);
>      } else {
> 

Thanks for the heads-up.  Though maybe it should just bypass the IOMMU
like virtio, I'll think about it.

Paolo