From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59668)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UVeBW-0001jH-JJ
	for qemu-devel@nongnu.org; Fri, 26 Apr 2013 04:39:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UVeBV-0005qL-AI
	for qemu-devel@nongnu.org; Fri, 26 Apr 2013 04:39:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:2464)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UVeBV-0005q0-2e
	for qemu-devel@nongnu.org; Fri, 26 Apr 2013 04:39:13 -0400
Message-ID: <517A3D11.9020702@redhat.com>
Date: Fri, 26 Apr 2013 10:38:41 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1366799842-18550-1-git-send-email-hutao@cn.fujitsu.com>
	<5177C23F.8050603@redhat.com> <5178291F.3090607@suse.de>
In-Reply-To: <5178291F.3090607@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] ich9: kill cmos_s3
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: Hu Tao <hutao@cn.fujitsu.com>, qemu-devel@nongnu.org

Il 24/04/2013 20:49, Andreas F=E4rber ha scritto:
> Am 24.04.2013 13:30, schrieb Paolo Bonzini:
>> Il 24/04/2013 12:37, Hu Tao ha scritto:
>>> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
>>
>> I had exactly the same patch in my 1.6 queue. :)
>>
>> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
>=20
> The commit message fails to explain *why* we can drop updating whatever
> RTC memory value there though?

Ultimately the argument was unused (see the ich9_pm_init part of the
patch).  This is now done with

    s->suspend_notifier.notify =3D rtc_notify_suspend;
    qemu_register_suspend_notifier(&s->suspend_notifier);

in hw/timer/mc146818rtc.c.

Paolo