From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60785) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVeGi-0006X6-Qd for qemu-devel@nongnu.org; Fri, 26 Apr 2013 04:44:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVeGh-0007ns-DM for qemu-devel@nongnu.org; Fri, 26 Apr 2013 04:44:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59019) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVeGh-0007no-4W for qemu-devel@nongnu.org; Fri, 26 Apr 2013 04:44:35 -0400 Message-ID: <517A3E64.8010103@redhat.com> Date: Fri, 26 Apr 2013 10:44:20 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1366804881-553-1-git-send-email-david@gibson.dropbear.id.au> <1366804881-553-5-git-send-email-david@gibson.dropbear.id.au> <1366816359.2918.703.camel@bling.home> <5178095D.7080808@redhat.com> <20130425063636.GQ4297@truffula.fritz.box> In-Reply-To: <20130425063636.GQ4297@truffula.fritz.box> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/5] vfio: Move container list to DMAContext List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: aik@ozlabs.ru, Alex Williamson , qemu-devel@nongnu.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Il 25/04/2013 08:36, David Gibson ha scritto: > On Wed, Apr 24, 2013 at 06:33:33PM +0200, Paolo Bonzini wrote: >> Il 24/04/2013 17:12, Alex Williamson ha scritto: >>>>> At the moment, vfio maintains a global list of containers >>>>> that are assumed to be more or less interchangeable, since >>>>> they are all set up with a MemoryListener to have all of >>>>> system memory mapped. However, that only makes sense if >>>>> all the containers are used on devices which really do >>>>> expect a dma address space identical to system memory. >>>>> >>>>> This patch moves towards that by making the list of >>>>> containers per DMAContext (which corresponds to a dma >>>>> address space) instead of global. >>> This seems like an unnecessary intrusion into common code. Why >>> not create a vfio specific list of dma objects, each with a >>> list of containers? Thanks, >> >> Yeah, I suggest that this is re-evaluated on top of the iommu >> patches. > >> You can find them at git://github.com/bonzini/qemu.git, branch >> iommu. It seems to work with pseries, at least my guest crashes >> at the same place with and without. USB works, and so do VGA and >> spapr-vscsi. > > Ok, I'll have a look when I get a chance. Any guesses as to when > they might reach mainline? If I get your Tested-by, early in 1.6. Paolo -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRej5jAAoJEBvWZb6bTYby6I0P/1lUAJhlrZ3mJ7h3HOK/Hee4 3U+csDnpp9kBkkoueWcfg/u5FCEIQ5MDII4/qvcJ6onLB6kp6cTyU5KRUQEFw+SF er/CfC3bIIo1wz3Ze6l9shOLa4bqiCawBGA5+dRKzh9KWuNwFmmkWjbUNBEgNcnb 0Iz2/jdL6KWEE8a7brCchJZpv6Ib0AhDMEp1wf6OwdJOWQx6BbLSr/SzFTb3/Wgs JOawqd6Dd/O45E+b0rDkXoF2Fit/XvrBSm0Hju8zvT3XnWeJxIMEiFroJIN053F2 /QHPWoF/xLRnP1JPhxiudSHZCKOMxQn/XBYa+olxt4MhRzEU+0F3bgUY19+sjfbh OAgtB5icjTP+gFPC2mw3wZZnHJ6Q0bWkLOSmQ4UXpcv88ZagJUDUTCiAWp2dPYnE czKLUC5IB1KAp8AWb3dqiym/BpDPuO0s/15t19e2/qJOZKU4PDQJD9hSnnbcYwRN dVMQWVpxKro2cZUXV6NbAhNXIdfM4WCdRDUDtRssAeaVOG5iiwdr481PC90+o7O1 gLLfKfsMytHflKwCre9ew6o+obwHXvSLbliou0kJAY0iuYyoAogu6zq4Eu+i+ia7 28JX5qpI/hRebacIKDryc0xGHGah06JHMLdITF7rLqH9fVg2X1Mz+4FAGwjUmO+m +23q7kaLcfBMjmKKfS3O =FkrW -----END PGP SIGNATURE-----