From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVedv-0004Tu-0X for qemu-devel@nongnu.org; Fri, 26 Apr 2013 05:08:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVedt-00079m-PC for qemu-devel@nongnu.org; Fri, 26 Apr 2013 05:08:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10595) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVedt-00079V-Hu for qemu-devel@nongnu.org; Fri, 26 Apr 2013 05:08:33 -0400 Message-ID: <517A4400.8090404@redhat.com> Date: Fri, 26 Apr 2013 11:08:16 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1366804881-553-1-git-send-email-david@gibson.dropbear.id.au> <1366804881-553-5-git-send-email-david@gibson.dropbear.id.au> <1366816359.2918.703.camel@bling.home> <5178095D.7080808@redhat.com> <20130425063636.GQ4297@truffula.fritz.box> <517A3E64.8010103@redhat.com> <517A3EE3.4050607@ozlabs.ru> <517A4051.8050302@redhat.com> <517A413E.3050905@ozlabs.ru> In-Reply-To: <517A413E.3050905@ozlabs.ru> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/5] vfio: Move container list to DMAContext List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: Alex Williamson , qemu-devel@nongnu.org, David Gibson Il 26/04/2013 10:56, Alexey Kardashevskiy ha scritto: > On 04/26/2013 06:52 PM, Paolo Bonzini wrote: >> Il 26/04/2013 10:46, Alexey Kardashevskiy ha scritto: >>> On 04/26/2013 06:44 PM, Paolo Bonzini wrote: >>>> Il 25/04/2013 08:36, David Gibson ha scritto: >>>>> On Wed, Apr 24, 2013 at 06:33:33PM +0200, Paolo Bonzini wrote: >>>>>> Il 24/04/2013 17:12, Alex Williamson ha scritto: >>>>>>>>> At the moment, vfio maintains a global list of containers >>>>>>>>> that are assumed to be more or less interchangeable, since >>>>>>>>> they are all set up with a MemoryListener to have all of >>>>>>>>> system memory mapped. However, that only makes sense if >>>>>>>>> all the containers are used on devices which really do >>>>>>>>> expect a dma address space identical to system memory. >>>>>>>>> >>>>>>>>> This patch moves towards that by making the list of >>>>>>>>> containers per DMAContext (which corresponds to a dma >>>>>>>>> address space) instead of global. >>>>>>> This seems like an unnecessary intrusion into common code. Why >>>>>>> not create a vfio specific list of dma objects, each with a >>>>>>> list of containers? Thanks, >>>>>> >>>>>> Yeah, I suggest that this is re-evaluated on top of the iommu >>>>>> patches. >>>>> >>>>>> You can find them at git://github.com/bonzini/qemu.git, branch >>>>>> iommu. It seems to work with pseries, at least my guest crashes >>>>>> at the same place with and without. USB works, and so do VGA and >>>>>> spapr-vscsi. >>>>> >>>>> Ok, I'll have a look when I get a chance. Any guesses as to when >>>>> they might reach mainline? >>>> >>>> If I get your Tested-by, early in 1.6. >>> >>> Emulated PCI works on ppc64/spapr so far. >> >> What about VIO? Doesn't it go through the IOMMU as well? I'm sure you >> can test it more than I did (it did break in Avi's original patches, so >> it must not be that bad...). > > I run QEMU with > -net nic,model=ibmveth -net user,hostfwd=tcp::5000-:22 > and run in the guest: "dhclient ; wget google.com" which worked fine. > When it damaged, it does not go further than dhclient :) Ok, that counts as a Tested-by from you, I guess. Paolo