From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVlFg-0004QE-68 for qemu-devel@nongnu.org; Fri, 26 Apr 2013 12:12:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVlFf-0002DL-1m for qemu-devel@nongnu.org; Fri, 26 Apr 2013 12:12:00 -0400 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:53269) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVlFe-0002D8-NU for qemu-devel@nongnu.org; Fri, 26 Apr 2013 12:11:58 -0400 Received: from /spool/local by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 26 Apr 2013 17:06:40 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 92536219002D for ; Fri, 26 Apr 2013 17:14:21 +0100 (BST) Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by b06cxnps3075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3QGBEUR52035778 for ; Fri, 26 Apr 2013 16:11:14 GMT Received: from d06av01.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3QGBOXs002504 for ; Fri, 26 Apr 2013 10:11:24 -0600 Message-ID: <517AA72B.8050805@de.ibm.com> Date: Fri, 26 Apr 2013 18:11:23 +0200 From: Christian Borntraeger MIME-Version: 1.0 References: <1366978377-16823-1-git-send-email-dingel@linux.vnet.ibm.com> <1366978377-16823-4-git-send-email-dingel@linux.vnet.ibm.com> <5AAF60BF-6909-45E4-8D61-B9B8B21CA95F@suse.de> <517AA059.4000400@de.ibm.com> <3D4AF3D5-CFA4-4352-8203-2739B17185A5@suse.de> <517AA4E8.2000103@de.ibm.com> <80F88DB4-AA83-42B4-9FC3-07F27DE611D0@suse.de> In-Reply-To: <80F88DB4-AA83-42B4-9FC3-07F27DE611D0@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 03/10] S390: Check Bootdevice Type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Christian Paro , qemu-devel@nongnu.org, Dominik Dingel On 26/04/13 18:05, Alexander Graf wrote: > > On 26.04.2013, at 18:01, Christian Borntraeger wrote: > >> On 26/04/13 17:48, Alexander Graf wrote: >> >>>> So I suggest to go with this patch and implement later on what we >>>> agree upon? >>> >>> I don't see how having "first device we find" is any better than a >>> rushed interface we need to agree on right before 1.5 hard freeze. >> >> Exactly, find first device isnt better ;-) >> See, the current code chooses the first subchannel that matches. This >> boils down to "a random disk" as soon as you have more than one. >> >> With this patch the user can at least specify the devno of the disk.It >> even works out of the box with libvirt. >> >> Let's just release 1.5 with the very simple one and then go for something >> awesome in the next version. >> >> Exactly - and having a list is more in the awesome area. Beiing able to >> specify the first disk and pass that in a register to the bios is of >> course not a full-features interface, but it works and can be changed. > > My main concern is backwards compatibility. If we introduce a command line > interface now, we have to support it forever. I'd rather only support one > interface, rather than 2 out of which one is only legacy for 1.5 compatibility. The cool thing is, that we dont introduce a command line interface in this patch. We just use the existing bootindex.