From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59263) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVrVZ-0001yt-HQ for qemu-devel@nongnu.org; Fri, 26 Apr 2013 18:52:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVrVW-00065f-PI for qemu-devel@nongnu.org; Fri, 26 Apr 2013 18:52:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33995) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVrVW-00065b-H3 for qemu-devel@nongnu.org; Fri, 26 Apr 2013 18:52:46 -0400 Message-ID: <517B0539.1020900@redhat.com> Date: Fri, 26 Apr 2013 16:52:41 -0600 From: Eric Blake MIME-Version: 1.0 References: <1366734308-11724-1-git-send-email-stefanha@redhat.com> <1366734308-11724-3-git-send-email-stefanha@redhat.com> In-Reply-To: <1366734308-11724-3-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2HLOEIPILDCQJQWPEXESN" Subject: Re: [Qemu-devel] [PATCH 2/3] block: add block_backup QMP command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Fam Zheng , qemu-devel@nongnu.org, Ian Main , Paolo Bonzini , dietmar@proxmox.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2HLOEIPILDCQJQWPEXESN Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/23/2013 10:25 AM, Stefan Hajnoczi wrote: > @block-backup >=20 > Start a point-in-time copy of a block device to a new destination. >=20 > @device: the name of the device whose writes should be mirrored. > +++ b/qapi-schema.json > @@ -1715,6 +1715,34 @@ > '*speed': 'int' } } > =20 > ## > +# @block-backup > +# > +# Start a point-in-time copy of a block device to a new destination. > +# > +# @device: the name of the device whose writes should be mirrored. two spaces? > +# > +# @target: the target of the new image. If the file exists, or if it > +# is a device, the existing file/device will be used as the n= ew > +# destination. If it does not exist, a new file will be crea= ted. > +# > +# @format: #optional the format of the new destination, default is to > +# probe if @mode is 'existing', else the format of the source= > +# > +# @mode: #optional whether and how QEMU should create a new image, def= ault is > +# 'absolute-paths'. > +# > +# @speed: #optional the maximum speed, in bytes per second > +# > +# Returns: nothing on success > +# If @device is not a valid block device, DeviceNotFound > +# > +# Since 1.5 1.6, now > +## > +{ 'command': 'block-backup', > + 'data': { 'device': 'str', 'target': 'str', '*format': 'str', > + '*mode': 'NewImageMode', '*speed': 'int' } } Looks reasonable (since it is closely aligned to drive-mirror). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2HLOEIPILDCQJQWPEXESN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRewU5AAoJEKeha0olJ0NqtGYH/j+m6cngWyUwLDVMDXOAj1wP h18Kw9vP6VOJ66jOXePh4tj8p6uai3Fri/8GE7uwZt7qZnzrsX9ZyYKc+rU+mrFx xTftg/XJ9c9L0DMm/EYVjWr/hdZ3/3cFa+qyZ0hgiF97iu9QtXqBK3uQCsrjCXyh DfEk90+WDJHXUh992li5bPIPoRnBiNyXd6voIXtElvmIkf3TOfcMkRxQ2SvjPpNX ZBKQt4yXHg3k23yYAfhGdvSLXy7YbNZdL72Cxv/3oH+4YK6zZ9SMQFRZcLdCeoi1 nPk679Ciz8xJJ0/tSyQVB7sOt/Cdd5WDeRP+A/0iB+Bv9bv/zVmjRm9UWwgaGKs= =HAKA -----END PGP SIGNATURE----- ------enig2HLOEIPILDCQJQWPEXESN--