From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59787) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVrb2-0005kY-4O for qemu-devel@nongnu.org; Fri, 26 Apr 2013 18:58:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVrb1-0007c7-21 for qemu-devel@nongnu.org; Fri, 26 Apr 2013 18:58:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2283) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVrb0-0007bv-PB for qemu-devel@nongnu.org; Fri, 26 Apr 2013 18:58:26 -0400 Message-ID: <517B0690.7080904@redhat.com> Date: Fri, 26 Apr 2013 16:58:24 -0600 From: Eric Blake MIME-Version: 1.0 References: <1366734308-11724-1-git-send-email-stefanha@redhat.com> <1366734308-11724-3-git-send-email-stefanha@redhat.com> In-Reply-To: <1366734308-11724-3-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2QPXTQLTXLVUQKCDEQGFP" Subject: Re: [Qemu-devel] [PATCH 2/3] block: add block_backup QMP command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Fam Zheng , qemu-devel@nongnu.org, Ian Main , Paolo Bonzini , dietmar@proxmox.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2QPXTQLTXLVUQKCDEQGFP Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/23/2013 10:25 AM, Stefan Hajnoczi wrote: > @block-backup >=20 > Start a point-in-time copy of a block device to a new destination. >=20 > @device: the name of the device whose writes should be mirrored. >=20 > @target: the target of the new image. If the file exists, or if it > is a device, the existing file/device will be used as the new > destination. If it does not exist, a new file will be created= =2E >=20 > @format: #optional the format of the new destination, default is to > probe if @mode is 'existing', else the format of the source >=20 > @mode: #optional whether and how QEMU should create a new image, defaul= t is > 'absolute-paths'. >=20 > @speed: #optional the maximum speed, in bytes per second >=20 > Returns: nothing on success > If @device is not a valid block device, DeviceNotFound This starts a new block job type; I assume the existing block-job-cancel and query-block-jobs can track it. I'd really love to see us change 'BlockJobInfo' to use an enum for 'type', instead of its open-coded 'str'. Likewise, the block-job related events in QMP/qmp-events.txt should be updated to refer to the enum instead of also being open-coded 'str'. Will this job be called "backup"? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2QPXTQLTXLVUQKCDEQGFP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRewaQAAoJEKeha0olJ0NqTv8IAKNT/RabqQel0rLuwgWxg5wO YwRHgUanbGiHOWqiWyAwdqK6f8w8CCRauB0PMpJMWuxfoL5L9nt6u3rXhpDFEZFY ndDunwnADA4OyCtQ9a8kgGCBEr4pODtWdeduRrCYr+Qx61z3RnMnWdlxCpLNhiRR tAFnAReDS5sOnSkGjNo+kpdhkyY9o2QvegCXmMmeGvGijzkiMK8exhLx/+fuKckO IlnGl9IBrZktejY+5iCd2fiA6Q0pCdVZjZl6lrMOepH0ZNzr4XllhH/lIh4ida5M i4+jLNc3tqx3JG0RmYon0NoEdm8rMBG4ZbvGXpWIwPddXoAE1n21XCILEjaaN80= =296d -----END PGP SIGNATURE----- ------enig2QPXTQLTXLVUQKCDEQGFP--