From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWjBG-0003Oa-TE for qemu-devel@nongnu.org; Mon, 29 Apr 2013 04:11:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UWjBC-0006ce-4M for qemu-devel@nongnu.org; Mon, 29 Apr 2013 04:11:26 -0400 Received: from mail-bk0-x22c.google.com ([2a00:1450:4008:c01::22c]:39287) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWjBB-0006cK-UI for qemu-devel@nongnu.org; Mon, 29 Apr 2013 04:11:22 -0400 Received: by mail-bk0-f44.google.com with SMTP id jk13so372226bkc.17 for ; Mon, 29 Apr 2013 01:11:20 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <517E2B1A.8000209@redhat.com> Date: Mon, 29 Apr 2013 10:11:06 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1366956141-2066-1-git-send-email-david@gibson.dropbear.id.au> <1366956141-2066-4-git-send-email-david@gibson.dropbear.id.au> <517A398C.6030104@redhat.com> <20130426113121.GB4360@truffula.fritz.box> <517A83CE.2070505@redhat.com> <20130427094927.GC20202@truffula.fritz.box> <517BC1F2.70405@redhat.com> <20130428015822.GE20202@truffula.fritz.box> In-Reply-To: <20130428015822.GE20202@truffula.fritz.box> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] vfio: Move container list to iommu MemoryRegion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: aik@ozlabs.ru, alex.williamson@redhat.com, qemu-devel@nongnu.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Il 28/04/2013 03:58, David Gibson ha scritto: >>> Ok, knowing about changes that happen in the IOMMU mapping is >>> indeed out of scope of MemoryListeners. What about adding a >>> NotifierList? Then VFIO can register a notifier and use it to >>> learn about "events" in the IOMMU mapping. The notifier data >>> can be a MemoryRegionSection or IOMMUTableEntry, whatever you >>> find more convenient. > For the generic case a Notifier could work in principle. Neither > of those structures is suitable as the data though: constructing a > MemoryRegionSection for every page we map into the IOTLB is far > too heavyweight, and the IOMMUTLBEntry doesn't contain the IOVA. It did in Avi's patch set. I removed it because it was unused. I can add it back if you need it. > Thinking over, I think what that mostly amounts to, is that if the > VFIO aspects of the address space are already wired up by the host > bridge, then the individual vfio-pci devices need a way of going > from their qemu iommu address space (which they get from > pci_dev->iommu) to the vfio specific information about that address > space. That can be done with just a hash table, no? Paolo -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRfisaAAoJEBvWZb6bTYby08gP/RcK8KfnW3bt4+sKui499rN0 N2YG+YOUySyrbChY2p9MQHmvQpHeJF+Qb6J2WkpqVHCewXox90uYaLMfUvHLGDuh tYusHQj9ew1afNYqUR19UIhiV11W+2Zy3GIDV6hEA0/lUEtvFYkKe4qqjYL6XPNh 3ZjrgYoGVZeXeN9FAcefVhKrZNkeG+QBg1FtXeCjinz3ZtjAsaR5QT8y8/quV7/W +i9IPh5bl7eMKPFKJl92uVnX7lF3IXkm+dBJGCMuTtp2e2uCGBiAop5FvvZdH25V VsYUxh57Mk6CFER8h23qGt7evU5QU7CS6Lq7mJav1sVJARtVGqv2Nizd8557UCgq EYsJx7iHFJrmxCiIx4yrzLO8fPtnvwcXsmthvLcC3N9FYYCNNgaMGAV3J2OSGHqC OkgpWWxHWokp1i1qumKGJH3KNd/3Yzys/KmeBf3t8Uk4sXFzHZcYFqr6qKopAGVw 9wLA/wBDUF9TOGg/DLcQuQ7de95uJQs7yQislcuXUS8gQ87hnvk3STCLvnPJwcvt WcsBJFj2H62cdKemoaMaDDtwwTNds/BwHNaiQp9DjIBj6Lq25c0tk4Xswv0lc/yn InsGeDVtCIUkEBHu9T8PD9Te2T59CgvpXjQ/ZEJkXnI5fDm1i1vda2xQx6Erp2ah UKPltbecB2Oj09Yul6XC =16N8 -----END PGP SIGNATURE-----