From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49801)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UWjTZ-0004BT-Cu
	for qemu-devel@nongnu.org; Mon, 29 Apr 2013 04:30:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UWjTU-0004oE-73
	for qemu-devel@nongnu.org; Mon, 29 Apr 2013 04:30:21 -0400
Received: from mail-bk0-x22b.google.com ([2a00:1450:4008:c01::22b]:33525)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UWjJN-00017u-Ji
	for qemu-devel@nongnu.org; Mon, 29 Apr 2013 04:19:49 -0400
Received: by mail-bk0-f43.google.com with SMTP id jm19so2517036bkc.16
	for <qemu-devel@nongnu.org>; Mon, 29 Apr 2013 01:19:48 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <517E2D17.4020401@redhat.com>
Date: Mon, 29 Apr 2013 10:19:35 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1367172276-23293-1-git-send-email-riegamaths@gmail.com>
In-Reply-To: <1367172276-23293-1-git-send-email-riegamaths@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Makefile: Fix build breakage
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dunrong Huang <riegamaths@gmail.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, qemu-devel <qemu-devel@nongnu.org>

Il 28/04/2013 20:04, Dunrong Huang ha scritto:
> The following error occurs when building dtc module:
> 
> 	CHK version_gen.h
> 	 CC libfdt/fdt.o
> cc1: error: dtc: No such file or directory [-Werror]
> cc1: all warnings being treated as errors
> make[1]: *** [libfdt/fdt.o] Error 1
> make: *** [subdir-dtc] Error 2
> 
> In rules.mak, "-I$(<D) -I$(@D)" was expanded to "-Idtc -I." when
> building submodule dct. Due to the using of "-Wmissing-include-dirs,
> a warning would be rarsed. To avoid it, use dtc as the first prerequisite
> so that "$(^D)" was expanded to "."
> 
> Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> Cc: Blue Swirl <blauwirbel@gmail.com>
> Signed-off-by: Dunrong Huang <riegamaths@gmail.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 8aca92f..64b0b1b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -148,7 +148,7 @@ $(SRC_PATH)/pixman/configure:
>  DTC_MAKE_ARGS=-I$(SRC_PATH)/dtc VPATH=$(SRC_PATH)/dtc -C dtc V="$(V)" LIBFDT_srcdir=$(SRC_PATH)/dtc/libfdt
>  DTC_CFLAGS=$(CFLAGS) $(QEMU_CFLAGS) -I$(BUILD_DIR)/dtc -I$(SRC_PATH)/dtc -I$(SRC_PATH)/dtc/libfdt
>  
> -subdir-dtc:dtc/libfdt dtc/tests
> +subdir-dtc:dtc dtc/libfdt dtc/tests
>  	$(call quiet-command,$(MAKE) $(DTC_MAKE_ARGS) CFLAGS="$(DTC_CFLAGS)" LDFLAGS="$(LDFLAGS)" ARFLAGS="$(ARFLAGS)" CC="$(CC)" AR="$(AR)" LD="$(LD)" $(SUBDIR_MAKEFLAGS) libfdt/libfdt.a,)
>  
>  dtc/%:
> 

Does it work if the "-I$(<D) -I$(@D)" is added to QEMU_INCLUDES instead
of QEMU_CFLAGS?

Paolo