From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWkMf-0005my-J1 for qemu-devel@nongnu.org; Mon, 29 Apr 2013 05:27:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UWkMe-00089C-D8 for qemu-devel@nongnu.org; Mon, 29 Apr 2013 05:27:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33521) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWkMe-00088t-5L for qemu-devel@nongnu.org; Mon, 29 Apr 2013 05:27:16 -0400 Message-ID: <517E3CE5.5030202@redhat.com> Date: Mon, 29 Apr 2013 11:27:01 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1366734308-11724-1-git-send-email-stefanha@redhat.com> <1366734308-11724-3-git-send-email-stefanha@redhat.com> <517B0690.7080904@redhat.com> <20130429072110.GA13488@stefanha-thinkpad.redhat.com> In-Reply-To: <20130429072110.GA13488@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] block: add block_backup QMP command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Fam Zheng , qemu-devel@nongnu.org, Ian Main , dietmar@proxmox.com Il 29/04/2013 09:21, Stefan Hajnoczi ha scritto: > > I'd really love to see us change 'BlockJobInfo' to use an enum for > > 'type', instead of its open-coded 'str'. Likewise, the block-job > > related events in QMP/qmp-events.txt should be updated to refer to the > > enum instead of also being open-coded 'str'. > > Since the block job QMP API has been in released I'm not sure changing > this is worthwhile. QEMU and libvirt would have to maintain > compatibility so the code will just be duplicated. I don't think this would change the actual data on the wire. However, it would let libvirt know the supported block job types by introspecting the enum. Paolo