From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49444)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UWnzO-00071t-H9
	for qemu-devel@nongnu.org; Mon, 29 Apr 2013 09:19:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UWnzJ-00043a-77
	for qemu-devel@nongnu.org; Mon, 29 Apr 2013 09:19:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:5733)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UWnzI-00043H-Vz
	for qemu-devel@nongnu.org; Mon, 29 Apr 2013 09:19:25 -0400
Message-ID: <517E73E2.2050604@redhat.com>
Date: Mon, 29 Apr 2013 15:21:38 +0200
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1366316544-1428-1-git-send-email-lersek@redhat.com>
	<1366316544-1428-8-git-send-email-lersek@redhat.com>
	<87li86xwk6.fsf@codemonkey.ws> <517A6158.7030306@redhat.com>
	<20130429082015.GA7597@redhat.com>
	<20130429123926.GA18936@morn.localdomain>
In-Reply-To: <20130429123926.GA18936@morn.localdomain>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 7/7] hw/i386: build ACPI MADT (APIC) for
 fw_cfg clients
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, "Michael S. Tsirkin" <mst@redhat.com>

On 04/29/13 14:39, Kevin O'Connor wrote:
> On Mon, Apr 29, 2013 at 11:20:15AM +0300, Michael S. Tsirkin wrote:

>> in particular, seabios wants to interpret presence
>> of any file in etc/acpi as a signal not to generate
>> its own tables.
> 
> Right.

In that case,

>> So merging this patch but without the config option will break
>> this plan. The only two ways I see are:
>> - merge this last patch with the config option, disabled by default
>>   the idea being we can improve it in-tree, gradually.
>> - keep this patch out of tree until we have a complete
>>   set of tables.
>>
>> Both are fine with me.
> 
> Why?  As long as QEMU places the new tables under new fwcfg entries,
> old seabios will totally ignore the new tables.  I don't see why a
> QEMU config option is needed - it's safe for QEMU to always create
> both old and new fwcfg entries.

the new-style fw_cfg entry for the MADT (= "etc/acpi/APIC") would
prevent the generation of all other (yet unexported by qemu) ACPI tables
in *new* seabios.

[SeaBIOS] [PATCH RFC 2/3] acpi: load and link tables from /etc/acpi/
<http://thread.gmane.org/gmane.comp.emulators.qemu/208457/focus=208458>

Thanks,
Laszlo